Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Side by Side Diff: chrome/browser/ui/intents/web_intent_picker_controller.h

Issue 10969016: web intents. Fix callbacks to restore tab management on service exit. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix comment Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_INTENTS_WEB_INTENT_PICKER_CONTROLLER_H_ 5 #ifndef CHROME_BROWSER_UI_INTENTS_WEB_INTENT_PICKER_CONTROLLER_H_
6 #define CHROME_BROWSER_UI_INTENTS_WEB_INTENT_PICKER_CONTROLLER_H_ 6 #define CHROME_BROWSER_UI_INTENTS_WEB_INTENT_PICKER_CONTROLLER_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
(...skipping 288 matching lines...) Expand 10 before | Expand all | Expand 10 after
299 // client page. 299 // client page.
300 content::WebIntentsDispatcher* intents_dispatcher_; 300 content::WebIntentsDispatcher* intents_dispatcher_;
301 301
302 // Weak pointer to the tab servicing the intent. Remembered in order to 302 // Weak pointer to the tab servicing the intent. Remembered in order to
303 // close it when a reply is sent. 303 // close it when a reply is sent.
304 content::WebContents* service_tab_; 304 content::WebContents* service_tab_;
305 305
306 // Request consumer used when asynchronously loading favicons. 306 // Request consumer used when asynchronously loading favicons.
307 CancelableRequestConsumerTSimple<size_t> favicon_consumer_; 307 CancelableRequestConsumerTSimple<size_t> favicon_consumer_;
308 308
309 base::WeakPtrFactory<WebIntentPickerController> weak_ptr_factory_; 309 base::WeakPtrFactory<WebIntentPickerController> weak_ptr_factory_;
please use gerrit instead 2012/09/20 16:38:30 Comment please.
Greg Billock 2012/09/20 16:45:19 Done.
310 310
311 // Timer factory for minimum display time of "waiting" dialog. 311 // Timer factory for minimum display time of "waiting" dialog.
312 base::WeakPtrFactory<WebIntentPickerController> timer_factory_; 312 base::WeakPtrFactory<WebIntentPickerController> timer_factory_;
313 313
314 // Weak pointers for the dispatcher OnSendReturnMessage will not be
315 // cancelled on picker close.
316 base::WeakPtrFactory<WebIntentPickerController> dispatcher_factory_;
please use gerrit instead 2012/09/20 16:38:30 What's the different between weak_ptr_factory_ and
Greg Billock 2012/09/20 16:45:19 Done.
317
314 // Bucket identifier for UMA reporting. Saved off in a field 318 // Bucket identifier for UMA reporting. Saved off in a field
315 // to avoid repeated calculation of the bucket across 319 // to avoid repeated calculation of the bucket across
316 // multiple UMA calls. Should be recalculated each time 320 // multiple UMA calls. Should be recalculated each time
317 // |intents_dispatcher_| is set. 321 // |intents_dispatcher_| is set.
318 web_intents::UMABucket uma_bucket_; 322 web_intents::UMABucket uma_bucket_;
319 323
320 DISALLOW_COPY_AND_ASSIGN(WebIntentPickerController); 324 DISALLOW_COPY_AND_ASSIGN(WebIntentPickerController);
321 }; 325 };
322 326
323 #endif // CHROME_BROWSER_UI_INTENTS_WEB_INTENT_PICKER_CONTROLLER_H_ 327 #endif // CHROME_BROWSER_UI_INTENTS_WEB_INTENT_PICKER_CONTROLLER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698