Pass a Feature* to IsAnyFeatureAvailableToContext instead of a string name.

Pass a Feature* to IsAnyFeatureAvailableToContext instead of a string name.

This makes it clear that we were never passing non-feature function names, which
lets us simplify the test.

BUG=305000
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241490

[not at google - send to devlin, 2013-12-18 01:55:14]

lgtm. you wil need to update extension_api_stub.cc to make android link.

https://codereview.chromium.org/109683007/diff/100001/chrome/common/extension...
File chrome/common/extensions/api/extension_api_unittest.cc (left):

https://codereview.chromium.org/109683007/diff/100001/chrome/common/extension...
chrome/common/extensions/api/extension_api_unittest.cc:396:
"runtime.getBackgroundPage",
what happened to these?

[Jeffrey Yasskin, 2013-12-18 02:14:59]

https://codereview.chromium.org/109683007/diff/100001/chrome/common/extension...
File chrome/common/extensions/api/extension_api_unittest.cc (left):

https://codereview.chromium.org/109683007/diff/100001/chrome/common/extension...
chrome/common/extensions/api/extension_api_unittest.cc:396:
"runtime.getBackgroundPage",
On 2013/12/18 01:55:14, kalman wrote:
> what happened to these?

runtime.getBackgroundPage isn't a feature, so it was exercising the logic in
IsAvailable that looks for subfeatures using concatenation, but looks for the
current feature by chaining up to the parent. This doesn't make a whole lot of
sense, so I didn't bother to keep it working when I switched the production code
to use Feature& everywhere. The fact that the production code *could* use
Feature& everywhere means this sort of edge case actually never happens, so we
don't need to test it. The rest of the "partially unprivileged" case is handled
by the "extension" test.

[not at google - send to devlin, 2013-12-18 02:18:10]

lgtm

https://codereview.chromium.org/109683007/diff/100001/chrome/common/extension...
File chrome/common/extensions/api/extension_api_unittest.cc (left):

https://codereview.chromium.org/109683007/diff/100001/chrome/common/extension...
chrome/common/extensions/api/extension_api_unittest.cc:396:
"runtime.getBackgroundPage",
On 2013/12/18 02:14:59, Jeffrey Yasskin wrote:
> On 2013/12/18 01:55:14, kalman wrote:
> > what happened to these?
> 
> runtime.getBackgroundPage isn't a feature, so it was exercising the logic in
> IsAvailable that looks for subfeatures using concatenation, but looks for the
> current feature by chaining up to the parent. This doesn't make a whole lot of
> sense, so I didn't bother to keep it working when I switched the production
code
> to use Feature& everywhere. The fact that the production code *could* use
> Feature& everywhere means this sort of edge case actually never happens, so we
> don't need to test it. The rest of the "partially unprivileged" case is
handled
> by the "extension" test.

sgtm.

[commit-bot: I haz the power, 2013-12-18 02:18:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jyasskin@chromium.org/109683007/110001

[commit-bot: I haz the power, 2013-12-18 04:53:51]

Change committed as 241490