chrome/common/extensions/features/base_feature_provider.h - Issue 109683007: Pass a Feature* to IsAnyFeatureAvailableToContext instead of a string name.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/features/base_feature_provider.h

Issue 109683007: Pass a Feature* to IsAnyFeatureAvailableToContext instead of a string name. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Update extension_api_stub.cc Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/api/extension_api_unittest.cc ('k') | chrome/common/extensions/features/base_feature_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/features/base_feature_provider.h

diff --git a/chrome/common/extensions/features/base_feature_provider.h b/chrome/common/extensions/features/base_feature_provider.h

index 8f7d32509d4f7afbad0695b0f12430551f11f937..6b9c46c1b707ada94069a44baf09b4c6e751ed9d 100644

--- a/chrome/common/extensions/features/base_feature_provider.h

+++ b/chrome/common/extensions/features/base_feature_provider.h

@@ -31,16 +31,17 @@ class BaseFeatureProvider : public FeatureProvider {

static FeatureProvider* GetByName(const std::string& name);

// Gets the feature |feature_name|, if it exists.

- virtual Feature* GetFeature(const std::string& feature_name) OVERRIDE;

- virtual Feature* GetParent(Feature* feature) OVERRIDE;

+ virtual Feature* GetFeature(const std::string& feature_name) const OVERRIDE;

+ virtual Feature* GetParent(Feature* feature) const OVERRIDE;

- virtual const std::vector<std::string>& GetAllFeatureNames() OVERRIDE;

+ virtual const std::vector<std::string>& GetAllFeatureNames() const OVERRIDE;

private:

typedef std::map<std::string, linked_ptr<Feature> > FeatureMap;

FeatureMap features_;

- std::vector<std::string> feature_names_;

+ // Populated on first use.

+ mutable std::vector<std::string> feature_names_;

FeatureFactory factory_;

};