Some extra testing for GpuDataManager.

Some extra testing for GpuDataManager.

BUG=
TEST=content_unittests
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=158119

[Zhenyao Mo, 2012-09-21 20:57:31]

jbauman: please review
kbr: owner approval

[jbauman, 2012-09-21 21:02:38]

lgtm

https://codereview.chromium.org/10968042/diff/1/content/browser/gpu/gpu_data_...
File content/browser/gpu/gpu_data_manager_impl_unittest.cc (right):

https://codereview.chromium.org/10968042/diff/1/content/browser/gpu/gpu_data_...
content/browser/gpu/gpu_data_manager_impl_unittest.cc:183:
manager->BlacklistCard();
It might also be nice to add a test (in a separate patch) where we register the
swiftshader path first, then blacklist the card, and ensure that also works.

[Zhenyao Mo, 2012-09-21 21:15:08]

On 2012/09/21 21:02:38, jbauman wrote:
> lgtm
> 
>
https://codereview.chromium.org/10968042/diff/1/content/browser/gpu/gpu_data_...
> File content/browser/gpu/gpu_data_manager_impl_unittest.cc (right):
> 
>
https://codereview.chromium.org/10968042/diff/1/content/browser/gpu/gpu_data_...
> content/browser/gpu/gpu_data_manager_impl_unittest.cc:183:
> manager->BlacklistCard();
> It might also be nice to add a test (in a separate patch) where we register
the
> swiftshader path first, then blacklist the card, and ensure that also works.

Good idea.  Just update the CL for this new test.  Please have another look.

[jbauman, 2012-09-21 21:19:14]

lgtm
Thanks for the change

[Ken Russell (switch to Gerrit), 2012-09-21 21:38:26]

lgtm