Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1033)

Unified Diff: content/browser/gpu/gpu_data_manager_impl_unittest.cc

Issue 10968042: Some extra testing for GpuDataManager. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/gpu/gpu_data_manager_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/gpu/gpu_data_manager_impl_unittest.cc
===================================================================
--- content/browser/gpu/gpu_data_manager_impl_unittest.cc (revision 157852)
+++ content/browser/gpu/gpu_data_manager_impl_unittest.cc (working copy)
@@ -166,15 +166,59 @@
manager->BlacklistCard();
EXPECT_FALSE(manager->GpuAccessAllowed());
+ EXPECT_EQ(content::GPU_FEATURE_TYPE_ALL,
+ manager->GetBlacklistedFeatures());
+ delete manager;
+}
+
+TEST_F(GpuDataManagerImplTest, SoftwareRendering) {
+ // Blacklist, then register SwiftShader.
+ GpuDataManagerImpl* manager = new GpuDataManagerImpl();
+ ASSERT_TRUE(manager);
+ EXPECT_EQ(0, manager->GetBlacklistedFeatures());
+ EXPECT_TRUE(manager->GpuAccessAllowed());
+ EXPECT_FALSE(manager->ShouldUseSoftwareRendering());
+
+ manager->BlacklistCard();
+ EXPECT_FALSE(manager->GpuAccessAllowed());
+ EXPECT_FALSE(manager->ShouldUseSoftwareRendering());
+
// If software rendering is enabled, even if we blacklist GPU,
// GPU process is still allowed.
- manager->software_rendering_ = true;
+ const FilePath test_path(FILE_PATH_LITERAL("AnyPath"));
+ manager->RegisterSwiftShaderPath(test_path);
+ EXPECT_TRUE(manager->ShouldUseSoftwareRendering());
EXPECT_TRUE(manager->GpuAccessAllowed());
+ EXPECT_EQ(content::GPU_FEATURE_TYPE_ACCELERATED_2D_CANVAS,
+ manager->GetBlacklistedFeatures());
delete manager;
}
+TEST_F(GpuDataManagerImplTest, SoftwareRendering2) {
+ // Register SwiftShader, then blacklist.
+ GpuDataManagerImpl* manager = new GpuDataManagerImpl();
+ ASSERT_TRUE(manager);
+ EXPECT_EQ(0, manager->GetBlacklistedFeatures());
+ EXPECT_TRUE(manager->GpuAccessAllowed());
+ EXPECT_FALSE(manager->ShouldUseSoftwareRendering());
+
+ const FilePath test_path(FILE_PATH_LITERAL("AnyPath"));
+ manager->RegisterSwiftShaderPath(test_path);
+ EXPECT_EQ(0, manager->GetBlacklistedFeatures());
+ EXPECT_TRUE(manager->GpuAccessAllowed());
+ EXPECT_FALSE(manager->ShouldUseSoftwareRendering());
+
+ manager->BlacklistCard();
+ EXPECT_TRUE(manager->GpuAccessAllowed());
+ EXPECT_TRUE(manager->ShouldUseSoftwareRendering());
+ EXPECT_EQ(content::GPU_FEATURE_TYPE_ACCELERATED_2D_CANVAS,
+ manager->GetBlacklistedFeatures());
+
+ delete manager;
+}
+
TEST_F(GpuDataManagerImplTest, GpuInfoUpdate) {
GpuDataManagerImpl* manager = new GpuDataManagerImpl();
ASSERT_TRUE(manager);
« no previous file with comments | « content/browser/gpu/gpu_data_manager_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698