content/browser/renderer_host/render_view_host_impl.h - Issue 10968037: Fix the issue that any tab/window closing hotkey will crash the Pepper Flash Fullscreen.

Unified Diff: content/browser/renderer_host/render_view_host_impl.h

Issue 10968037: Fix the issue that any tab/window closing hotkey will crash the Pepper Flash Fullscreen. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Changes in response to John's suggestion. Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/renderer_host/render_view_host_impl.h

diff --git a/content/browser/renderer_host/render_view_host_impl.h b/content/browser/renderer_host/render_view_host_impl.h

index bfb34bca25567e6362b7193b8329d0367e7cf7de..2c462ccf92567e3d12913d2d2eccfcfaafa7f875 100644

--- a/content/browser/renderer_host/render_view_host_impl.h

+++ b/content/browser/renderer_host/render_view_host_impl.h

@@ -124,6 +124,10 @@ class CONTENT_EXPORT RenderViewHostImpl

// spec) space. This is useful when restoring contentses, but most callers

// should pass in NULL which will cause a new SessionStorageNamespace to be

// created.

+ //

+ // If this object outlives |widget_delegate|,

+ // RenderWidgetHostImpl::DetachDelegate() must be called when

+ // |widget_delegate| goes away.

jam 2012/09/22 00:01:34 since this derives from RenderWidgetHostImpl, is t

yzshen1 2012/09/22 00:28:08 I imagine that people wouldn't be careful enough t

jam 2012/09/24 16:47:00 what I was trying to say is that this class doesn'

yzshen1 2012/09/24 16:59:41 Removed. Thanks! On 2012/09/24 16:47:00, John Abd-

RenderViewHostImpl(

SiteInstance* instance,

RenderViewHostDelegate* delegate,

« no previous file with comments | « no previous file | content/browser/renderer_host/render_widget_host_delegate.h » ('j') | content/browser/renderer_host/render_widget_host_impl.h » ('J')