Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Side by Side Diff: content/browser/renderer_host/render_view_host_impl.h

Issue 10968037: Fix the issue that any tab/window closing hotkey will crash the Pepper Flash Fullscreen. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Changes in response to John's suggestion. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_ 5 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_
6 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_ 6 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 106 matching lines...) Expand 10 before | Expand all | Expand 10 after
117 // |routing_id| could be a valid route id, or it could be MSG_ROUTING_NONE, in 117 // |routing_id| could be a valid route id, or it could be MSG_ROUTING_NONE, in
118 // which case RenderWidgetHost will create a new one. |swapped_out| indicates 118 // which case RenderWidgetHost will create a new one. |swapped_out| indicates
119 // whether the view should initially be swapped out (e.g., for an opener 119 // whether the view should initially be swapped out (e.g., for an opener
120 // frame being rendered by another process). 120 // frame being rendered by another process).
121 // 121 //
122 // The |session_storage_namespace| parameter allows multiple render views and 122 // The |session_storage_namespace| parameter allows multiple render views and
123 // WebContentses to share the same session storage (part of the WebStorage 123 // WebContentses to share the same session storage (part of the WebStorage
124 // spec) space. This is useful when restoring contentses, but most callers 124 // spec) space. This is useful when restoring contentses, but most callers
125 // should pass in NULL which will cause a new SessionStorageNamespace to be 125 // should pass in NULL which will cause a new SessionStorageNamespace to be
126 // created. 126 // created.
127 //
128 // If this object outlives |widget_delegate|,
129 // RenderWidgetHostImpl::DetachDelegate() must be called when
130 // |widget_delegate| goes away.
jam 2012/09/22 00:01:34 since this derives from RenderWidgetHostImpl, is t
yzshen1 2012/09/22 00:28:08 I imagine that people wouldn't be careful enough t
jam 2012/09/24 16:47:00 what I was trying to say is that this class doesn'
yzshen1 2012/09/24 16:59:41 Removed. Thanks! On 2012/09/24 16:47:00, John Abd-
127 RenderViewHostImpl( 131 RenderViewHostImpl(
128 SiteInstance* instance, 132 SiteInstance* instance,
129 RenderViewHostDelegate* delegate, 133 RenderViewHostDelegate* delegate,
130 RenderWidgetHostDelegate* widget_delegate, 134 RenderWidgetHostDelegate* widget_delegate,
131 int routing_id, 135 int routing_id,
132 bool swapped_out, 136 bool swapped_out,
133 SessionStorageNamespace* session_storage_namespace); 137 SessionStorageNamespace* session_storage_namespace);
134 virtual ~RenderViewHostImpl(); 138 virtual ~RenderViewHostImpl();
135 139
136 // RenderViewHost implementation. 140 // RenderViewHost implementation.
(...skipping 541 matching lines...) Expand 10 before | Expand all | Expand 10 after
678 DISALLOW_COPY_AND_ASSIGN(RenderViewHostImpl); 682 DISALLOW_COPY_AND_ASSIGN(RenderViewHostImpl);
679 }; 683 };
680 684
681 #if defined(COMPILER_MSVC) 685 #if defined(COMPILER_MSVC)
682 #pragma warning(pop) 686 #pragma warning(pop)
683 #endif 687 #endif
684 688
685 } // namespace content 689 } // namespace content
686 690
687 #endif // CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_ 691 #endif // CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698