Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Issue 10967068: Stop importing js_helper.dart explicitly in the core library. (Closed)

Created:
8 years, 3 months ago by Lasse Reichstein Nielsen
Modified:
8 years, 2 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org, Johnni Winther
Visibility:
Public.

Description

Remove direct imports of js_helper.dart. Committed: https://code.google.com/p/dart/source/detail?r=13279

Patch Set 1 #

Patch Set 2 : Undid changes not necessary for main compiler change. #

Total comments: 1

Patch Set 3 : Updated to tip of tree. #

Patch Set 4 : Merged to tip-of-tree. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -28 lines) Patch
M lib/compiler/implementation/apiimpl.dart View 1 2 3 2 chunks +3 lines, -4 lines 0 comments Download
M lib/compiler/implementation/compiler.dart View 1 2 3 1 chunk +20 lines, -5 lines 0 comments Download
M lib/compiler/implementation/lib/core.dart View 1 2 1 chunk +1 line, -3 lines 0 comments Download
D lib/compiler/implementation/lib/coreimpl.dart View 1 1 chunk +0 lines, -2 lines 0 comments Download
M lib/compiler/implementation/lib/interceptors.dart View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M lib/compiler/implementation/lib/js_helper.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M lib/compiler/implementation/lib/math_patch.dart View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M lib/compiler/implementation/patch_parser.dart View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M lib/compiler/implementation/scanner/scanner_task.dart View 1 2 3 1 chunk +14 lines, -8 lines 0 comments Download
M tests/compiler/dart2js/dart_backend_test.dart View 1 2 3 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Lasse Reichstein Nielsen
Similar to our previously discussed change. Can't be committed until the mirror system can handle ...
8 years, 3 months ago (2012-09-24 09:32:05 UTC) #1
ahe
I'd like to split the compiler changes from the library changes. Small changes makes it ...
8 years, 3 months ago (2012-09-24 10:54:59 UTC) #2
Lasse Reichstein Nielsen
PTAL
8 years, 3 months ago (2012-09-24 11:47:16 UTC) #3
ahe
On 2012/09/24 11:47:16, Lasse Reichstein Nielsen wrote: > PTAL Where are the compiler changes?
8 years, 3 months ago (2012-09-24 12:57:33 UTC) #4
ahe
On 2012/09/24 12:57:33, ahe wrote: > On 2012/09/24 11:47:16, Lasse Reichstein Nielsen wrote: > > ...
8 years, 3 months ago (2012-09-24 12:57:57 UTC) #5
Lasse Reichstein Nielsen
https://codereview.chromium.org/10967068/diff/4001/lib/compiler/implementation/compiler.dart File lib/compiler/implementation/compiler.dart (right): https://codereview.chromium.org/10967068/diff/4001/lib/compiler/implementation/compiler.dart#newcode385 lib/compiler/implementation/compiler.dart:385: identicalFunction = coreLibrary.find(const SourceString('identical')); These two look like they ...
8 years, 3 months ago (2012-09-24 13:52:03 UTC) #6
Lasse Reichstein Nielsen
PTAL :)
8 years, 2 months ago (2012-09-26 14:36:27 UTC) #7
Lasse Reichstein Nielsen
Ping
8 years, 2 months ago (2012-10-05 08:09:32 UTC) #8
ahe
8 years, 2 months ago (2012-10-05 08:16:17 UTC) #9
LGTM!

Powered by Google App Engine
This is Rietveld 408576698