Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(17)

Issue 10967066: Use correct timezone information on Solaris (Closed)

Created:
6 years, 12 months ago by mmalecki
Modified:
6 years, 11 months ago
CC:
v8-dev
Visibility:
Public.

Description

Use correct timezone information on Solaris `timezone` variable contains the difference, in seconds, between UTC and local standard time (see `man 3 localtime` on Solaris). Call to `tzset` is required to apply contents of `TZ` variable to `timezone` variable. BUG=v8:2064 Committed: https://code.google.com/p/v8/source/detail?r=12802

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M src/platform-solaris.cc View 1 chunk +2 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
mmalecki
6 years, 12 months ago (2012-09-23 23:18:11 UTC) #1
Yang
LocalTimeOffset is supposed to take daylight saving time into account. tzset() seems to set the ...
6 years, 12 months ago (2012-09-24 07:43:55 UTC) #2
aleksander.adamowski
On 2012/09/24 07:43:55, Yang wrote: > LocalTimeOffset is supposed to take daylight saving time into ...
6 years, 11 months ago (2012-10-13 18:51:31 UTC) #3
aleksander.adamowski
I'm downloading a SmartOS ISO image so that I can test my theory with arbutrary ...
6 years, 11 months ago (2012-10-13 18:55:28 UTC) #4
aleksander.adamowski
Some more test results - they suggest that all is OK with Maciej Malecki's patch. ...
6 years, 11 months ago (2012-10-15 22:31:21 UTC) #5
Sven Panne
Some general drive-by comments: The whole time zone/DST code seems to be a mess for ...
6 years, 11 months ago (2012-10-16 06:40:11 UTC) #6
aleksander.adamowski
On 2012/10/16 06:40:11, Sven Panne wrote: > * Handling the time zone in one place ...
6 years, 11 months ago (2012-10-16 07:41:25 UTC) #7
Yang
6 years, 11 months ago (2012-10-23 13:03:57 UTC) #8
On 2012/10/16 07:41:25, aleksander.adamowski wrote:
> On 2012/10/16 06:40:11, Sven Panne wrote:
> >    * Handling the time zone in one place and handling DST somewhere else
looks
> > wrong, unless the spec somehow forces us to do it this confusing way.
> 
> I think that this has been decomposed into two operations precisely because of
> code quality/single responsibility and deduplication.
> 
> On a given platform, you can imagine having to use platform-specific method of
> getting the time zone offset, but standard POSIX approach for getting the DST
> offset.

LGTM. Landing...

Powered by Google App Engine
This is Rietveld 408576698