Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 1096483003: Disable flaky PreferPasswordFormManagerWhichFinishedMatching on Mac. (Closed)

Created:
5 years, 8 months ago by maniscalco
Modified:
5 years, 8 months ago
CC:
chromium-reviews, gcasto+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org, vabr+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable flaky PreferPasswordFormManagerWhichFinishedMatching on Mac. TBR=vabr@chromium.org BUG=477812 Committed: https://crrev.com/631a0021d3d4cbc6bbfaa5b4dcd140ee89199617 Cr-Commit-Position: refs/heads/master@{#325534}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M chrome/browser/password_manager/password_manager_browsertest.cc View 1 chunk +10 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
maniscalco
5 years, 8 months ago (2015-04-16 22:11:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1096483003/1
5 years, 8 months ago (2015-04-16 22:15:42 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-16 22:57:52 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/631a0021d3d4cbc6bbfaa5b4dcd140ee89199617 Cr-Commit-Position: refs/heads/master@{#325534}
5 years, 8 months ago (2015-04-16 22:59:51 UTC) #6
Mike West
LGTM, thanks for disabling.
5 years, 8 months ago (2015-04-17 04:10:00 UTC) #8
vabr (Chromium)
5 years, 8 months ago (2015-04-17 06:02:50 UTC) #9
Message was sent while issue was closed.
LGTM, thanks!

Powered by Google App Engine
This is Rietveld 408576698