Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3300)

Unified Diff: chrome/browser/password_manager/password_manager_browsertest.cc

Issue 1096483003: Disable flaky PreferPasswordFormManagerWhichFinishedMatching on Mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/password_manager/password_manager_browsertest.cc
diff --git a/chrome/browser/password_manager/password_manager_browsertest.cc b/chrome/browser/password_manager/password_manager_browsertest.cc
index 1bf5e34fbc2cf61e583307933ed89daa4c1463a3..f759c2bb152c07a38ecf65c780b279a65185689a 100644
--- a/chrome/browser/password_manager/password_manager_browsertest.cc
+++ b/chrome/browser/password_manager/password_manager_browsertest.cc
@@ -1366,8 +1366,17 @@ IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTest, NoLastLoadGoodLastLoad) {
// all-but-action match. Normally, the former should be preferred, but if the
// former has not finished matching, and the latter has, the latter should be
// used (otherwise we'd give up even though we could have saved the password).
+//
+// Disabled on Mac due to flakiness: http://crbug.com/477812
+#if defined(OS_MACOSX)
+#define MAYBE_PreferPasswordFormManagerWhichFinishedMatching \
+ DISABLED_PreferPasswordFormManagerWhichFinishedMatching
+#else
+#define MAYBE_PreferPasswordFormManagerWhichFinishedMatching \
+ PreferPasswordFormManagerWhichFinishedMatching
+#endif
IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTest,
- PreferPasswordFormManagerWhichFinishedMatching) {
+ MAYBE_PreferPasswordFormManagerWhichFinishedMatching) {
NavigateToFile("/password/create_form_copy_on_submit.html");
NavigationObserver observer(WebContents());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698