Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1005)

Issue 1096203008: Don't report errors on file transfer events, because most files aren't ones we are interested in. (Closed)

Created:
5 years, 8 months ago by Steve McKay
Modified:
5 years, 8 months ago
Reviewers:
fukino
CC:
chromium-reviews, tfarina, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't report errors on file transfer events, because most files aren't ones we are interested in. BUG= Committed: https://crrev.com/d4fbd7b5d5e85b36536cd3e5098d3ab24ad729fd Cr-Commit-Position: refs/heads/master@{#326998}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M ui/file_manager/file_manager/background/js/import_history.js View 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Steve McKay
Bye-bye file-transfer-mark-imported-by-url error.
5 years, 8 months ago (2015-04-24 23:57:17 UTC) #2
fukino
lgtm
5 years, 8 months ago (2015-04-27 03:54:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1096203008/1
5 years, 8 months ago (2015-04-27 03:54:51 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-27 04:49:49 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-27 04:50:49 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d4fbd7b5d5e85b36536cd3e5098d3ab24ad729fd
Cr-Commit-Position: refs/heads/master@{#326998}

Powered by Google App Engine
This is Rietveld 408576698