Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Unified Diff: ui/file_manager/file_manager/background/js/import_history.js

Issue 1096203008: Don't report errors on file transfer events, because most files aren't ones we are interested in. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/file_manager/file_manager/background/js/import_history.js
diff --git a/ui/file_manager/file_manager/background/js/import_history.js b/ui/file_manager/file_manager/background/js/import_history.js
index e69ce262ae4ecd9e01e448bba914642a6b42e841..cb22333ef8706f10c6faca9d775cab556f964532 100644
--- a/ui/file_manager/file_manager/background/js/import_history.js
+++ b/ui/file_manager/file_manager/background/js/import_history.js
@@ -967,12 +967,10 @@ importer.DriveSyncWatcher.prototype.updateSyncStatus_ =
*/
importer.DriveSyncWatcher.prototype.onFileTransfersUpdated_ =
function(status) {
- // TODO(smckay): What if the file isn't one we're interested in....?
- // I guess we just let the call to markImportedByUrl fail for now.
+ // If the synced file it isn't one we copied,
+ // the call to mark by url will just fail...fine by us.
if (status.transferState === 'completed') {
- this.history_.markImportedByUrl(status.fileUrl)
- .catch(
- importer.getLogger().catcher('file-transfer-mark-imported-by-url'));
+ this.history_.markImportedByUrl(status.fileUrl);
}
};
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698