net/socket/socks_client_socket.h - Issue 1096203006: Collect all ConnectionAttempts from both sockets in TransportConnectJob.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/socks_client_socket.h

Issue 1096203006: Collect all ConnectionAttempts from both sockets in TransportConnectJob. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@domrel_serverip1

Patch Set: Return fake ConnectionAttempt in MockTCPClientSocket Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/socket/socks_client_socket.h

diff --git a/net/socket/socks_client_socket.h b/net/socket/socks_client_socket.h

index 66fab4523c4c6ef5cdfff46f53ff1a9acda863af..ee2918a60944d8a83676d36223cb38233501fdc0 100644

--- a/net/socket/socks_client_socket.h

+++ b/net/socket/socks_client_socket.h

@@ -52,6 +52,9 @@ class NET_EXPORT_PRIVATE SOCKSClientSocket : public StreamSocket {

bool WasNpnNegotiated() const override;

NextProto GetNegotiatedProtocol() const override;

bool GetSSLInfo(SSLInfo* ssl_info) override;

+ void GetConnectionAttempts(ConnectionAttempts* out) const override;

+ void ClearConnectionAttempts() override {}

+ void AddConnectionAttempts(const ConnectionAttempts& attempts) override {}

// Socket implementation.

int Read(IOBuffer* buf,

« no previous file with comments | « net/socket/socks5_client_socket.cc ('k') | net/socket/socks_client_socket.cc » ('j') | no next file with comments »