net/socket/socks_client_socket.cc - Issue 1096203006: Collect all ConnectionAttempts from both sockets in TransportConnectJob.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/socks_client_socket.cc

Issue 1096203006: Collect all ConnectionAttempts from both sockets in TransportConnectJob. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@domrel_serverip1

Patch Set: Return fake ConnectionAttempt in MockTCPClientSocket Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/socket/socks_client_socket.cc

diff --git a/net/socket/socks_client_socket.cc b/net/socket/socks_client_socket.cc

index fd16f832915a5870d12aea02b82a7b36e762c0ea..dbdc0251768fcd64eb29711bfcd2fbaf57046b2d 100644

--- a/net/socket/socks_client_socket.cc

+++ b/net/socket/socks_client_socket.cc

@@ -172,7 +172,10 @@ bool SOCKSClientSocket::GetSSLInfo(SSLInfo* ssl_info) {

}

NOTREACHED();

return false;

+void SOCKSClientSocket::GetConnectionAttempts(ConnectionAttempts* out) const {

+ out->clear();

}

// Read is called by the transport layer above to read. This can only be done

« no previous file with comments | « net/socket/socks_client_socket.h ('k') | net/socket/ssl_client_socket_nss.h » ('j') | no next file with comments »