Collect all ConnectionAttempts from both sockets in TransportConnectJob.

net/socket/transport_client_socket_pool.h

Index: net/socket/transport_client_socket_pool.h
diff --git a/net/socket/transport_client_socket_pool.h b/net/socket/transport_client_socket_pool.h
index de57d18aa80f803c24ddce436fce8d11035b306f..f7dc67857a6057a631cd9afae1bbb250442b1611 100644
--- a/net/socket/transport_client_socket_pool.h
+++ b/net/socket/transport_client_socket_pool.h
@@ -17,6 +17,7 @@
 #include "net/dns/single_request_host_resolver.h"
 #include "net/socket/client_socket_pool.h"
 #include "net/socket/client_socket_pool_base.h"
+#include "net/socket/connection_attempts.h"
 
 namespace net {
 
@@ -196,6 +197,8 @@ class NET_EXPORT_PRIVATE TransportConnectJob : public ConnectJob {
   // Otherwise, it returns a net error code.
   int ConnectInternal() override;
 
+  void CopyConnectionAttemptsFromClientSocketHandles();
+
   TransportConnectJobHelper helper_;
 
   scoped_ptr<StreamSocket> transport_socket_;
@@ -211,6 +214,10 @@ class NET_EXPORT_PRIVATE TransportConnectJob : public ConnectJob {
   int resolve_result_;
   int connect_result_;
 
+  // Saved when connections fail and passed up in GetAdditionalErrorState.

[Randy Smith (Not in Mondays), 2015/05/12 20:11:09]

Ok, so I want to seriously bulk up this comment, and possibly include some of
the information here in the CL description.  What I think is happening is that:
* As a socket is used for connection attempts, connection failures accumulate on
that socket.
* When the TransportConnectJob hits a connection success case, it copies all of
the connection attempt information from the socket that isn't being returned to
the socket that is being returned.
* When the TransportConnectJob gives up in failure, it pulls all the information
out of the sockets and puts it in these variables, where it's available to
GetAdditionalErrorState().

Now that I've written that out, I'd like it to be that level of clear in the CL
description, and I'm ok with just adding a comment here "Only used in failure
case; on success the failed connection attempt information is stored on the
socket to be returned."

That ok?

[Deprecated (see juliatuttle), 2015/05/13 18:22:29]

Done.

+  ConnectionAttempts connection_attempts_;
+  ConnectionAttempts fallback_connection_attempts_;
+
   DISALLOW_COPY_AND_ASSIGN(TransportConnectJob);
 };