Collect all ConnectionAttempts from both sockets in TransportConnectJob.

net/socket/transport_client_socket_pool.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_SOCKET_TRANSPORT_CLIENT_SOCKET_POOL_H_
 #define NET_SOCKET_TRANSPORT_CLIENT_SOCKET_POOL_H_
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/time/time.h"
 #include "base/timer/timer.h"
 #include "net/base/host_port_pair.h"
 #include "net/dns/host_resolver.h"
 #include "net/dns/single_request_host_resolver.h"
 #include "net/socket/client_socket_pool.h"
 #include "net/socket/client_socket_pool_base.h"
+#include "net/socket/connection_attempts.h"
 
 namespace net {
 
 class ClientSocketFactory;
 
 typedef base::Callback<int(const AddressList&, const BoundNetLog& net_log)>
 OnHostResolutionCallback;
 
 class NET_EXPORT_PRIVATE TransportSocketParams
     : public base::RefCounted<TransportSocketParams> {
@@ skipping 159 matching lines @@
 
   // Not part of the state machine.
   void DoIPv6FallbackTransportConnect();
   void DoIPv6FallbackTransportConnectComplete(int result);
 
   // Begins the host resolution and the TCP connect.  Returns OK on success
   // and ERR_IO_PENDING if it cannot immediately service the request.
   // Otherwise, it returns a net error code.
   int ConnectInternal() override;
 
+  void CopyConnectionAttemptsFromClientSocketHandles();
+
   TransportConnectJobHelper helper_;
 
   scoped_ptr<StreamSocket> transport_socket_;
 
   scoped_ptr<StreamSocket> fallback_transport_socket_;
   scoped_ptr<AddressList> fallback_addresses_;
   base::TimeTicks fallback_connect_start_time_;
   base::OneShotTimer<TransportConnectJob> fallback_timer_;
 
   // Track the interval between this connect and previous connect.
   ConnectInterval interval_between_connects_;
 
   int resolve_result_;
   int connect_result_;
 
+  // Saved when connections fail and passed up in GetAdditionalErrorState.

[Randy Smith (Not in Mondays), 2015/05/12 20:11:09]

Ok, so I want to seriously bulk up this comment, and possibly include some of
the information here in the CL description.  What I think is happening is that:
* As a socket is used for connection attempts, connection failures accumulate on
that socket.
* When the TransportConnectJob hits a connection success case, it copies all of
the connection attempt information from the socket that isn't being returned to
the socket that is being returned.
* When the TransportConnectJob gives up in failure, it pulls all the information
out of the sockets and puts it in these variables, where it's available to
GetAdditionalErrorState().

Now that I've written that out, I'd like it to be that level of clear in the CL
description, and I'm ok with just adding a comment here "Only used in failure
case; on success the failed connection attempt information is stored on the
socket to be returned."

That ok?

[Deprecated (see juliatuttle), 2015/05/13 18:22:29]

Done.

+  ConnectionAttempts connection_attempts_;
+  ConnectionAttempts fallback_connection_attempts_;
+
   DISALLOW_COPY_AND_ASSIGN(TransportConnectJob);
 };
 
 class NET_EXPORT_PRIVATE TransportClientSocketPool : public ClientSocketPool {
  public:
   typedef TransportSocketParams SocketParams;
 
   TransportClientSocketPool(
       int max_sockets,
       int max_sockets_per_group,
@@ skipping 130 matching lines @@
         break;
     }
   } while (rv != ERR_IO_PENDING && next_state_ != STATE_NONE);
 
   return rv;
 }
 
 }  // namespace net
 
 #endif  // NET_SOCKET_TRANSPORT_CLIENT_SOCKET_POOL_H_