Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5384)

Unified Diff: chrome/browser/resources/settings/search_page/search_page.html

Issue 1096143003: Add chrome.searchEnginesPrivate API and Search Settings page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add a test Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/search_page/search_page.html
diff --git a/chrome/browser/resources/settings/search_page/search_page.html b/chrome/browser/resources/settings/search_page/search_page.html
new file mode 100644
index 0000000000000000000000000000000000000000..cd82fe94b311896b4fffb5cf4bb0bb69b9f23f08
--- /dev/null
+++ b/chrome/browser/resources/settings/search_page/search_page.html
@@ -0,0 +1,35 @@
+<link rel="import" href="chrome://resources/polymer/polymer/polymer.html">
+<link rel="import" href="chrome://resources/polymer/core-menu/core-menu.html">
+<link rel="import" href="chrome://resources/polymer/paper-item/paper-item.html">
+<link rel="import" href="chrome://resources/polymer/paper-shadow/paper-shadow.html">
+<link rel="import" href="chrome://resources/cr_elements/cr_dropdown_menu/cr_dropdown_menu.html">
+<link rel="import" href="chrome://md-settings/settings_page/settings_page_header.html">
Jeremy Klein 2015/04/22 17:37:46 Not needed.
Oren Blasberg 2015/04/22 18:25:41 Done.
+<link rel="import" href="chrome://md-settings/checkbox/checkbox.html">
+<link rel="import" href="search_page_style.html">
Jeremy Klein 2015/04/22 17:37:46 Don't we also need core-style?
Oren Blasberg 2015/04/22 18:25:41 search_page_style.html pulls that in.
Jeremy Klein 2015/04/22 18:51:14 This should too. It directly has a core-style elem
+
+<polymer-element name="cr-settings-search-page">
+ <template>
+ <link rel="stylesheet" href="chrome://md-settings/settings_page/settings_page.css">
+ <core-style ref="searchPageStyle"></core-style>
+ <paper-shadow layout vertical cross-fade>
+ <span i18n-content="searchExplanation"></span>
Jeremy Klein 2015/04/22 17:37:46 nit: I'm not sure a span is really the right choic
Oren Blasberg 2015/04/22 18:25:41 Done.
+
+ <div class="search-engines" layout horizontal center>
+ <cr-dropdown-menu class="search-engines-dropdown">
+ <core-menu id="searchEnginesMenu" class="menu" valueAttr="value"
+ selectedAttribute=""
+ selected="{{defaultEngineGuid}}">
+ <template repeat="{{engine in searchEngines}}">
+ <paper-item value="{{engine.guid}}">{{engine.name}}</paper-item>
Jeremy Klein 2015/04/22 17:37:45 Let's switch "value" to "guid" to be more specific
Oren Blasberg 2015/04/22 18:25:41 Done.
+ </template>
+ </core-menu>
+ </cr-dropdown-menu>
+
+ <cr-button class="manage-search-engines"
+ i18n-content="searchManageButtonLabel" raised>
+ </cr-button>
+ </div>
+ </paper-shadow>
+ </template>
+ <script src="search_page.js"></script>
+</polymer-element>

Powered by Google App Engine
This is Rietveld 408576698