chrome/browser/resources/settings/search_page/search_page.html - Issue 1096143003: Add chrome.searchEnginesPrivate API and Search Settings page.

Side by Side Diff: chrome/browser/resources/settings/search_page/search_page.html

Issue 1096143003: Add chrome.searchEnginesPrivate API and Search Settings page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add a test Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/extensions/api/search_engines_private/search_engines_private_api.h ('K') | « chrome/browser/resources/settings/routes.html ('k') | chrome/browser/resources/settings/search_page/search_page.js » ('j') | chrome/browser/resources/settings/search_page/search_page.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <link rel="import" href="chrome://resources/polymer/polymer/polymer.html">

	2 <link rel="import" href="chrome://resources/polymer/core-menu/core-menu.html">

	3 <link rel="import" href="chrome://resources/polymer/paper-item/paper-item.html">

	4 <link rel="import" href="chrome://resources/polymer/paper-shadow/paper-shadow.ht ml">

	5 <link rel="import" href="chrome://resources/cr_elements/cr_dropdown_menu/cr_drop down_menu.html">

	6 <link rel="import" href="chrome://md-settings/settings_page/settings_page_header .html">
	Jeremy Klein 2015/04/22 17:37:46 Not needed. Not needed. Oren Blasberg 2015/04/22 18:25:41 Done. Show quoted text On 2015/04/22 17:37:46, Jeremy Klein wrote: > Not needed. Done.
	7 <link rel="import" href="chrome://md-settings/checkbox/checkbox.html">

	8 <link rel="import" href="search_page_style.html">
	Jeremy Klein 2015/04/22 17:37:46 Don't we also need core-style? Don't we also need core-style? Oren Blasberg 2015/04/22 18:25:41 search_page_style.html pulls that in. Show quoted text On 2015/04/22 17:37:46, Jeremy Klein wrote: > Don't we also need core-style? search_page_style.html pulls that in. Jeremy Klein 2015/04/22 18:51:14 This should too. It directly has a core-style elem Show quoted text On 2015/04/22 18:25:41, Oren Blasberg wrote: > On 2015/04/22 17:37:46, Jeremy Klein wrote: > > Don't we also need core-style? > > search_page_style.html pulls that in. This should too. It directly has a core-style element below so it needs to depend on it. We shouldn't rely on transitive dependencies.
	9

	10 <polymer-element name="cr-settings-search-page">

	11 <template>

	12 <link rel="stylesheet" href="chrome://md-settings/settings_page/settings_pag e.css">

	13 <core-style ref="searchPageStyle"></core-style>

	14 <paper-shadow layout vertical cross-fade>

	15 <span i18n-content="searchExplanation"></span>
	Jeremy Klein 2015/04/22 17:37:46 nit: I'm not sure a span is really the right choic nit: I'm not sure a span is really the right choice here. Should it be a <p>? Maybe a <div>? Oren Blasberg 2015/04/22 18:25:41 Done. Show quoted text On 2015/04/22 17:37:46, Jeremy Klein wrote: > nit: I'm not sure a span is really the right choice here. Should it be a <p>? > Maybe a <div>? Done.
	16

	17 <div class="search-engines" layout horizontal center>

	18 <cr-dropdown-menu class="search-engines-dropdown">

	19 <core-menu id="searchEnginesMenu" class="menu" valueAttr="value"

	20 selectedAttribute=""

	21 selected="{{defaultEngineGuid}}">

	22 <template repeat="{{engine in searchEngines}}">

	23 <paper-item value="{{engine.guid}}">{{engine.name}}</paper-item>
	Jeremy Klein 2015/04/22 17:37:45 Let's switch "value" to "guid" to be more specific Let's switch "value" to "guid" to be more specific. Oren Blasberg 2015/04/22 18:25:41 Done. Show quoted text On 2015/04/22 17:37:45, Jeremy Klein wrote: > Let's switch "value" to "guid" to be more specific. Done.
	24 </template>

	25 </core-menu>

	26 </cr-dropdown-menu>

	27

	28 <cr-button class="manage-search-engines"

	29 i18n-content="searchManageButtonLabel" raised>

	30 </cr-button>

	31 </div>

	32 </paper-shadow>

	33 </template>

	34 <script src="search_page.js"></script>

	35 </polymer-element>

OLD	NEW