Issue 10961066: Revert 158199 - extensions: Add ExtensionView interface.

Issue 10961066: Revert 158199 - extensions: Add ExtensionView interface. (Closed)

Created:
8 years, 3 months ago by tfarina

Modified:
8 years, 3 months ago

Reviewers:
tfarina

CC:
chromium-reviews, jeremya+watch_chromium.org, Aaron Boodman, mihaip-chromium-reviews_chromium.org, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 158199 - extensions: Add ExtensionView interface. We abstract all ports (android, cocoa, gtk and views) behind this interface. That way chrome/browser/extensions/ does not need to include any platform-specific ui header files. Popup window was not appearing for externsions. Hence the revert. BUG=125846, 151843 TBR=ben@chromium.org Review URL: https://codereview.chromium.org/10913243 TBR=tfarina@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=158219

Patch Set 1 #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+384 lines, -532 lines)			Patch
M	chrome/browser/extensions/extension_host.h	View	4 chunks	+40 lines, -8 lines	0 comments	Download
M	chrome/browser/extensions/extension_host.cc	View	12 chunks	+34 lines, -37 lines	0 comments	Download
MM	chrome/browser/extensions/extension_host_mac.mm	View	2 chunks	+1 line, -3 lines	0 comments	Download
D	chrome/browser/extensions/extension_view.h	View	1 chunk	+0 lines, -68 lines	0 comments	Download
D	chrome/browser/extensions/extension_view_container.h	View	1 chunk	+0 lines, -26 lines	0 comments	Download
M	chrome/browser/ui/android/extensions/extension_view_android.h	View	1 chunk	+9 lines, -15 lines	0 comments	Download
M	chrome/browser/ui/android/extensions/extension_view_android.cc	View	2 chunks	+0 lines, -44 lines	0 comments	Download
M	chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm	View	5 chunks	+13 lines, -13 lines	0 comments	Download
MM	chrome/browser/ui/cocoa/extensions/extension_view_mac.h	View	3 chunks	+48 lines, -15 lines	0 comments	Download
M	chrome/browser/ui/cocoa/extensions/extension_view_mac.mm	View	5 chunks	+20 lines, -41 lines	0 comments	Download
M	chrome/browser/ui/cocoa/infobars/extension_infobar_controller.mm	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	chrome/browser/ui/gtk/extensions/extension_popup_gtk.h	View	3 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/gtk/extensions/extension_popup_gtk.cc	View	5 chunks	+8 lines, -13 lines	0 comments	Download
MM	chrome/browser/ui/gtk/extensions/extension_view_gtk.h	View	3 chunks	+29 lines, -16 lines	0 comments	Download
M	chrome/browser/ui/gtk/extensions/extension_view_gtk.cc	View	3 chunks	+15 lines, -47 lines	0 comments	Download
M	chrome/browser/ui/gtk/extensions/shell_window_gtk.h	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/gtk/infobars/extension_infobar_gtk.h	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/gtk/infobars/extension_infobar_gtk.cc	View	4 chunks	+9 lines, -10 lines	0 comments	Download
M	chrome/browser/ui/views/extensions/extension_dialog.h	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/views/extensions/extension_dialog.cc	View	8 chunks	+12 lines, -21 lines	0 comments	Download
M	chrome/browser/ui/views/extensions/extension_popup.h	View	3 chunks	+4 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/views/extensions/extension_popup.cc	View	3 chunks	+3 lines, -8 lines	0 comments	Download
M	chrome/browser/ui/views/extensions/extension_view_views.h	View	4 chunks	+37 lines, -21 lines	0 comments	Download
M	chrome/browser/ui/views/extensions/extension_view_views.cc	View	6 chunks	+84 lines, -94 lines	0 comments	Download
M	chrome/browser/ui/views/infobars/extension_infobar.cc	View	3 chunks	+6 lines, -10 lines	0 comments	Download
M	chrome/chrome_browser_extensions.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages