Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Side by Side Diff: chrome/browser/ui/views/infobars/extension_infobar.cc

Issue 10961066: Revert 158199 - extensions: Add ExtensionView interface. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/infobars/extension_infobar.h" 5 #include "chrome/browser/ui/views/infobars/extension_infobar.h"
6 6
7 #include "chrome/browser/extensions/extension_context_menu_model.h" 7 #include "chrome/browser/extensions/extension_context_menu_model.h"
8 #include "chrome/browser/extensions/extension_host.h" 8 #include "chrome/browser/extensions/extension_host.h"
9 #include "chrome/browser/extensions/extension_infobar_delegate.h" 9 #include "chrome/browser/extensions/extension_infobar_delegate.h"
10 #include "chrome/browser/infobars/infobar_tab_helper.h" 10 #include "chrome/browser/infobars/infobar_tab_helper.h"
11 #include "chrome/browser/platform_util.h" 11 #include "chrome/browser/platform_util.h"
12 #include "chrome/browser/ui/views/extensions/extension_view_views.h"
13 #include "chrome/browser/ui/views/frame/browser_view.h" 12 #include "chrome/browser/ui/views/frame/browser_view.h"
14 #include "chrome/common/extensions/extension.h" 13 #include "chrome/common/extensions/extension.h"
15 #include "chrome/common/extensions/extension_constants.h" 14 #include "chrome/common/extensions/extension_constants.h"
16 #include "chrome/common/extensions/extension_icon_set.h" 15 #include "chrome/common/extensions/extension_icon_set.h"
17 #include "chrome/common/extensions/extension_resource.h" 16 #include "chrome/common/extensions/extension_resource.h"
18 #include "grit/theme_resources.h" 17 #include "grit/theme_resources.h"
19 #include "ui/base/animation/slide_animation.h" 18 #include "ui/base/animation/slide_animation.h"
20 #include "ui/base/resource/resource_bundle.h" 19 #include "ui/base/resource/resource_bundle.h"
21 #include "ui/gfx/canvas.h" 20 #include "ui/gfx/canvas.h"
22 #include "ui/gfx/image/canvas_image_source.h" 21 #include "ui/gfx/image/canvas_image_source.h"
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
95 GetDelegate()->set_observer(NULL); 94 GetDelegate()->set_observer(NULL);
96 } 95 }
97 96
98 void ExtensionInfoBar::Layout() { 97 void ExtensionInfoBar::Layout() {
99 InfoBarView::Layout(); 98 InfoBarView::Layout();
100 99
101 gfx::Size menu_size = menu_->GetPreferredSize(); 100 gfx::Size menu_size = menu_->GetPreferredSize();
102 menu_->SetBounds(StartX(), OffsetY(menu_size), menu_size.width(), 101 menu_->SetBounds(StartX(), OffsetY(menu_size), menu_size.width(),
103 menu_size.height()); 102 menu_size.height());
104 103
105 ExtensionViewViews* view = static_cast<ExtensionViewViews*>( 104 GetDelegate()->extension_host()->view()->SetBounds(
106 GetDelegate()->extension_host()->GetExtensionView()); 105 menu_->bounds().right() + kMenuHorizontalMargin,
107 view->SetBounds(menu_->bounds().right() + kMenuHorizontalMargin, 106 arrow_height(),
108 arrow_height(), 107 std::max(0, EndX() - StartX() - ContentMinimumWidth()),
109 std::max(0, EndX() - StartX() - ContentMinimumWidth()), 108 height() - arrow_height() - 1);
110 height() - arrow_height() - 1);
111 } 109 }
112 110
113 void ExtensionInfoBar::ViewHierarchyChanged(bool is_add, 111 void ExtensionInfoBar::ViewHierarchyChanged(bool is_add,
114 views::View* parent, 112 views::View* parent,
115 views::View* child) { 113 views::View* child) {
116 if (!is_add || (child != this) || (menu_ != NULL)) { 114 if (!is_add || (child != this) || (menu_ != NULL)) {
117 InfoBarView::ViewHierarchyChanged(is_add, parent, child); 115 InfoBarView::ViewHierarchyChanged(is_add, parent, child);
118 return; 116 return;
119 } 117 }
120 118
121 menu_ = new views::MenuButton(NULL, string16(), this, false); 119 menu_ = new views::MenuButton(NULL, string16(), this, false);
122 menu_->SetVisible(false); 120 menu_->SetVisible(false);
123 menu_->set_focusable(true); 121 menu_->set_focusable(true);
124 AddChildView(menu_); 122 AddChildView(menu_);
125 123
126 extensions::ExtensionHost* extension_host = GetDelegate()->extension_host(); 124 extensions::ExtensionHost* extension_host = GetDelegate()->extension_host();
127 ExtensionViewViews* view = 125 AddChildView(extension_host->view());
128 static_cast<ExtensionViewViews*>(extension_host->GetExtensionView());
129 AddChildView(view);
130 126
131 // This must happen after adding all other children so InfoBarView can ensure 127 // This must happen after adding all other children so InfoBarView can ensure
132 // the close button is the last child. 128 // the close button is the last child.
133 InfoBarView::ViewHierarchyChanged(is_add, parent, child); 129 InfoBarView::ViewHierarchyChanged(is_add, parent, child);
134 130
135 // This must happen after adding all children because it can trigger layout, 131 // This must happen after adding all children because it can trigger layout,
136 // which assumes that particular children (e.g. the close button) have already 132 // which assumes that particular children (e.g. the close button) have already
137 // been added. 133 // been added.
138 const extensions::Extension* extension = extension_host->extension(); 134 const extensions::Extension* extension = extension_host->extension();
139 extension_misc::ExtensionIcons image_size = 135 extension_misc::ExtensionIcons image_size =
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
188 184
189 scoped_refptr<ExtensionContextMenuModel> options_menu_contents = 185 scoped_refptr<ExtensionContextMenuModel> options_menu_contents =
190 new ExtensionContextMenuModel(extension, browser_); 186 new ExtensionContextMenuModel(extension, browser_);
191 DCHECK_EQ(menu_, source); 187 DCHECK_EQ(menu_, source);
192 RunMenuAt(options_menu_contents.get(), menu_, views::MenuItemView::TOPLEFT); 188 RunMenuAt(options_menu_contents.get(), menu_, views::MenuItemView::TOPLEFT);
193 } 189 }
194 190
195 ExtensionInfoBarDelegate* ExtensionInfoBar::GetDelegate() { 191 ExtensionInfoBarDelegate* ExtensionInfoBar::GetDelegate() {
196 return delegate_ ? delegate_->AsExtensionInfoBarDelegate() : NULL; 192 return delegate_ ? delegate_->AsExtensionInfoBarDelegate() : NULL;
197 } 193 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/views/extensions/extension_view_views.cc ('k') | chrome/chrome_browser_extensions.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698