Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 1096093004: Correctly stop models when stopping NonUIDataTypeController. (Closed)

Created:
5 years, 8 months ago by bzanotti
Modified:
5 years, 8 months ago
Reviewers:
maniscalco
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, maxbogue+watch_chromium.org, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Correctly stop models when stopping NonUIDataTypeController. When NonUIDataTypeController was stopped while in the ASSOCIATING state, the models were not stopped even though this state is only accessible when the models are already loaded. BUG=479737 Committed: https://crrev.com/6eaa0a3fbc876b081de7504aaf9647f040671dbc Cr-Commit-Position: refs/heads/master@{#326758}

Patch Set 1 #

Patch Set 2 : Fix the tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M components/sync_driver/non_ui_data_type_controller.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/sync_driver/non_ui_data_type_controller_unittest.cc View 1 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
bzanotti
Please take a look. Note that I'm not very familiar with this code. The ASSOCIATING ...
5 years, 8 months ago (2015-04-22 14:33:44 UTC) #2
bzanotti
maniscalco@: Please take a look.
5 years, 8 months ago (2015-04-23 15:49:41 UTC) #3
maniscalco
Thanks for finding and fixing! LGTM
5 years, 8 months ago (2015-04-23 16:59:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1096093004/20001
5 years, 8 months ago (2015-04-24 08:23:37 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-24 08:26:54 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 08:27:46 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6eaa0a3fbc876b081de7504aaf9647f040671dbc
Cr-Commit-Position: refs/heads/master@{#326758}

Powered by Google App Engine
This is Rietveld 408576698