Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/sync_driver/non_ui_data_type_controller.cc

Issue 1096093004: Correctly stop models when stopping NonUIDataTypeController. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix the tests Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/sync_driver/non_ui_data_type_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/sync_driver/non_ui_data_type_controller.cc
diff --git a/components/sync_driver/non_ui_data_type_controller.cc b/components/sync_driver/non_ui_data_type_controller.cc
index df189b08bdb27de537f61c141c0d5297e5c177db..eb86a9ab863c635af3580d46ad2b70f365cafe4f 100644
--- a/components/sync_driver/non_ui_data_type_controller.cc
+++ b/components/sync_driver/non_ui_data_type_controller.cc
@@ -122,6 +122,7 @@ void NonUIDataTypeController::Stop() {
return; // The datatype was never activated, we're done.
case ASSOCIATING:
state_ = STOPPING;
+ StopModels();
// We continue on to deactivate the datatype and stop the local service.
break;
case MODEL_LOADED:
« no previous file with comments | « no previous file | components/sync_driver/non_ui_data_type_controller_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698