Fix array allocation overflow check on arm/arm64/mips.

runtime/vm/assembler_arm64.cc

Index: runtime/vm/assembler_arm64.cc
===================================================================
--- runtime/vm/assembler_arm64.cc	(revision 45266)
+++ runtime/vm/assembler_arm64.cc	(working copy)
@@ -1373,6 +1373,7 @@
     const uword top_address = heap->TopAddress(space);
     LoadImmediate(temp_reg, top_address, pp);
     ldr(instance_reg, Address(temp_reg));
+    // TODO(koda): Protect against unsigned overflow here.
     AddImmediate(instance_reg, instance_reg, instance_size, pp);

[zra, 2015/04/21 14:55:27]

AddImmediateSetFlags

Why TODO?

 
     // instance_reg: potential next object start.
@@ -1419,7 +1420,7 @@
     LoadImmediate(temp1, heap->TopAddress(space), PP);
     ldr(instance, Address(temp1, 0));  // Potential new object start.
     AddImmediate(end_address, instance, instance_size, PP);

[zra, 2015/04/21 14:55:27]

AddImmediateSetFlags

[koda, 2015/04/21 16:08:46]

Done.

-    b(failure, VS);
+    b(failure, CS);  // Fail on unsigned overflow.
 
     // Check if the allocation fits into the remaining space.
     // instance: potential new object start.