runtime/vm/assembler_arm.cc - Issue 1096063002: Fix array allocation overflow check on arm/arm64/mips.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/assembler_arm.cc

Issue 1096063002: Fix array allocation overflow check on arm/arm64/mips. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/assembler_arm.cc

===================================================================

--- runtime/vm/assembler_arm.cc (revision 45266)

+++ runtime/vm/assembler_arm.cc (working copy)

@@ -3387,6 +3387,7 @@

const uword top_address = heap->TopAddress(space);

LoadImmediate(temp_reg, top_address);

ldr(instance_reg, Address(temp_reg));

+ // TODO(koda): Protect against unsigned overflow here.

AddImmediate(instance_reg, instance_size);

zra 2015/04/21 14:55:27 Assembler::AddImmediateSetFlags(instance_reg, inst

// instance_reg: potential next object start.

@@ -3435,7 +3436,7 @@

LoadImmediate(temp1, heap->TopAddress(space));

ldr(instance, Address(temp1, 0)); // Potential new object start.

AddImmediate(end_address, instance, instance_size);

zra 2015/04/21 14:55:27 AddImmediateSetFlags

koda 2015/04/21 16:08:46 Done.

- b(failure, VS);

+ b(failure, CS); // Branch if unsigned overflow.

// Check if the allocation fits into the remaining space.

// instance: potential new object start.

« no previous file with comments | « runtime/tests/vm/vm.status ('k') | runtime/vm/assembler_arm64.cc » ('j') | runtime/vm/assembler_arm64.cc » ('J')