chrome/browser/android/chrome_web_contents_delegate_android.h - Issue 1095913002: Fix window.open issue in Document mode on Android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/chrome_web_contents_delegate_android.h

Issue 1095913002: Fix window.open issue in Document mode on Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add GuestViewBase delegate method Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/android/chrome_web_contents_delegate_android.h

diff --git a/chrome/browser/android/chrome_web_contents_delegate_android.h b/chrome/browser/android/chrome_web_contents_delegate_android.h

index c1c681184341367733900304746ebac3f0a17148..749a19f204283bc129866afec7034f910bfc9809 100644

--- a/chrome/browser/android/chrome_web_contents_delegate_android.h

+++ b/chrome/browser/android/chrome_web_contents_delegate_android.h

@@ -69,6 +69,7 @@ class ChromeWebContentsDelegateAndroid

content::WebContents* OpenURLFromTab(

content::WebContents* source,

const content::OpenURLParams& params) override;

+ bool ShouldResumeRequestsForCreatedWindow() override;

void AddNewContents(content::WebContents* source,

content::WebContents* new_contents,

WindowOpenDisposition disposition,