Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: chrome/browser/android/chrome_web_contents_delegate_android.cc

Issue 1095913002: Fix window.open issue in Document mode on Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add GuestViewBase delegate method Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/chrome_web_contents_delegate_android.cc
diff --git a/chrome/browser/android/chrome_web_contents_delegate_android.cc b/chrome/browser/android/chrome_web_contents_delegate_android.cc
index ecc988db5ce157217c62eee5d0aeee3fe6cf0344..7867ae17c1060cff6fe50d4955f6674dbd051156 100644
--- a/chrome/browser/android/chrome_web_contents_delegate_android.cc
+++ b/chrome/browser/android/chrome_web_contents_delegate_android.cc
@@ -7,6 +7,7 @@
#include "base/android/jni_android.h"
#include "base/android/jni_string.h"
#include "base/command_line.h"
+#include "chrome/browser/android/feature_utilities.h"
#include "chrome/browser/chrome_notification_types.h"
#include "chrome/browser/file_select_helper.h"
#include "chrome/browser/media/media_capture_devices_dispatcher.h"
@@ -305,6 +306,11 @@ WebContents* ChromeWebContentsDelegateAndroid::OpenURLFromTab(
return WebContentsDelegateAndroid::OpenURLFromTab(source, params);
}
+bool ChromeWebContentsDelegateAndroid::ShouldResumeRequestsForCreatedWindow() {
+ return chrome::android::GetDocumentModeValue() ==
+ chrome::android::RUNNING_MODE_TABBED_MODE;
+}
+
void ChromeWebContentsDelegateAndroid::AddNewContents(
WebContents* source,
WebContents* new_contents,

Powered by Google App Engine
This is Rietveld 408576698