content/renderer/pepper/ppb_graphics_3d_impl.cc - Issue 1095893002: gpu: Fix some context lost marking glitches+leaks and add UMA stats

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/pepper/ppb_graphics_3d_impl.cc

Issue 1095893002: gpu: Fix some context lost marking glitches+leaks and add UMA stats (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/common/gpu/client/command_buffer_metrics.h ('K') | « content/renderer/pepper/pepper_video_encoder_host.cc ('k') | content/renderer/render_thread_impl.cc » ('j') | gpu/command_buffer/service/gles2_cmd_decoder.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/pepper/ppb_graphics_3d_impl.cc

diff --git a/content/renderer/pepper/ppb_graphics_3d_impl.cc b/content/renderer/pepper/ppb_graphics_3d_impl.cc

index b703cef31d160d102429cfff385896f30514e09c..2de5e1092e0e158715d0bb81580070febb2b3462 100644

--- a/content/renderer/pepper/ppb_graphics_3d_impl.cc

+++ b/content/renderer/pepper/ppb_graphics_3d_impl.cc

@@ -312,7 +312,7 @@ bool PPB_Graphics3D_Impl::InitRaw(

return false;

sync_point_ = command_buffer_->InsertSyncPoint();

- command_buffer_->SetChannelErrorCallback(base::Bind(

+ command_buffer_->SetContextLostCallback(base::Bind(

&PPB_Graphics3D_Impl::OnContextLost, weak_ptr_factory_.GetWeakPtr()));

command_buffer_->SetOnConsoleMessageCallback(base::Bind(