content/common/gpu/gpu_command_buffer_stub.cc - Issue 1095893002: gpu: Fix some context lost marking glitches+leaks and add UMA stats

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/gpu_command_buffer_stub.cc

Issue 1095893002: gpu: Fix some context lost marking glitches+leaks and add UMA stats (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/common/gpu/client/command_buffer_metrics.h ('K') | « content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc ('k') | content/common/gpu/gpu_messages.h » ('j') | gpu/command_buffer/service/gles2_cmd_decoder.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/gpu/gpu_command_buffer_stub.cc

diff --git a/content/common/gpu/gpu_command_buffer_stub.cc b/content/common/gpu/gpu_command_buffer_stub.cc

index e14cf986092b9c8817dcd3024e2474890734c368..de475a5cdc0383f6e5871e7e9c3fe33c6316e9df 100644

--- a/content/common/gpu/gpu_command_buffer_stub.cc

+++ b/content/common/gpu/gpu_command_buffer_stub.cc

@@ -671,7 +671,7 @@ void GpuCommandBufferStub::OnParseError() {

DCHECK(command_buffer_.get());

gpu::CommandBuffer::State state = command_buffer_->GetLastState();

IPC::Message* msg = new GpuCommandBufferMsg_Destroyed(

- route_id_, state.context_lost_reason);

+ route_id_, state.context_lost_reason, state.error);

msg->set_unblock(true);

Send(msg);

@@ -1089,7 +1089,7 @@ void GpuCommandBufferStub::MarkContextLost() {

command_buffer_->SetContextLostReason(gpu::error::kUnknown);

if (decoder_)

- decoder_->LoseContext(GL_UNKNOWN_CONTEXT_RESET_ARB);

+ decoder_->MarkContextLost(gpu::error::kUnknown);

command_buffer_->SetParseError(gpu::error::kLostContext);

}