content/common/gpu/client/command_buffer_proxy_impl.h - Issue 1095893002: gpu: Fix some context lost marking glitches+leaks and add UMA stats

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/client/command_buffer_proxy_impl.h

Issue 1095893002: gpu: Fix some context lost marking glitches+leaks and add UMA stats (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/common/gpu/client/command_buffer_metrics.h ('K') | « content/common/gpu/client/command_buffer_metrics.cc ('k') | content/common/gpu/client/command_buffer_proxy_impl.cc » ('j') | gpu/command_buffer/service/gles2_cmd_decoder.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/gpu/client/command_buffer_proxy_impl.h

diff --git a/content/common/gpu/client/command_buffer_proxy_impl.h b/content/common/gpu/client/command_buffer_proxy_impl.h

index 2da5bbc2727f2bb2262f7b6d84ff4d5708be8ed1..6e73c823d5b9b5530101b48f3eec29d3ee5b6100 100644

--- a/content/common/gpu/client/command_buffer_proxy_impl.h

+++ b/content/common/gpu/client/command_buffer_proxy_impl.h

@@ -120,7 +120,7 @@ class CommandBufferProxyImpl

int GetRouteID() const;

bool ProduceFrontBuffer(const gpu::Mailbox& mailbox);

- void SetChannelErrorCallback(const base::Closure& callback);

+ void SetContextLostCallback(const base::Closure& callback);

typedef base::Callback<void(const gpu::MemoryAllocation&)>

MemoryAllocationChangedCallback;

@@ -175,7 +175,8 @@ class CommandBufferProxyImpl

// Message handlers:

void OnUpdateState(const gpu::CommandBuffer::State& state);

- void OnDestroyed(gpu::error::ContextLostReason reason);

+ void OnDestroyed(gpu::error::ContextLostReason reason,

+ gpu::error::Error error);

void OnConsoleMessage(const GPUCommandBufferConsoleMessage& message);

void OnSetMemoryAllocation(const gpu::MemoryAllocation& allocation);

void OnSignalSyncPointAck(uint32 id);

@@ -208,7 +209,7 @@ class CommandBufferProxyImpl

int32 last_put_offset_;

int32 last_barrier_put_offset_;

- base::Closure channel_error_callback_;

+ base::Closure context_lost_callback_;

MemoryAllocationChangedCallback memory_allocation_changed_callback_;