Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/tcmalloc/chromium/src/free_list.cc

Issue 10957067: Ensure we mask freelist pointers properly on 32-bit Linux (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/tcmalloc/chromium/src/free_list.cc
===================================================================
--- third_party/tcmalloc/chromium/src/free_list.cc (revision 158339)
+++ third_party/tcmalloc/chromium/src/free_list.cc (working copy)
@@ -82,7 +82,8 @@
inline void* MaskPtr(void* p) {
// Maximize ASLR entropy and guarantee the result is an invalid address.
- const uintptr_t q = ~(reinterpret_cast<intptr_t>(TCMalloc_SystemAlloc) >> 13);
+ const uintptr_t q = ~(reinterpret_cast<uintptr_t>(TCMalloc_SystemAlloc)
jar (doing other things) 2012/09/24 21:59:54 nit: rename q--> mask
jschuh 2012/09/24 22:06:00 Done.
+ >> 13) | 1;
// Do not mask NULL pointers, otherwise we could leak address state.
if (p)
return reinterpret_cast<void*>(reinterpret_cast<uintptr_t>(p) ^ q);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698