Ensure we mask freelist pointers properly on 32-bit Linux

third_party/tcmalloc/chromium/src/free_list.cc

 // Copyright (c) 2011, Google Inc.
 // All rights reserved.
 //
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 // notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
@@ skipping 64 matching lines @@
 namespace {
 void EnsureNonLoop(void* node, void* next) {
   // We only have time to do minimal checking.  We don't traverse the list, but
   // only look for an immediate loop (cycle back to ourself).
   if (node != next) return;
   Log(kCrash, __FILE__, __LINE__, "Circular loop in list detected: ", next);
 }
 
 inline void* MaskPtr(void* p) {
   // Maximize ASLR entropy and guarantee the result is an invalid address.
-  const uintptr_t q = ~(reinterpret_cast<intptr_t>(TCMalloc_SystemAlloc) >> 13);
+  const uintptr_t q = ~(reinterpret_cast<uintptr_t>(TCMalloc_SystemAlloc)

[jar (doing other things), 2012/09/24 21:59:54]

nit: rename q--> mask

[jschuh, 2012/09/24 22:06:00]

Done.

+                        >> 13) | 1;
   // Do not mask NULL pointers, otherwise we could leak address state.
   if (p)
     return reinterpret_cast<void*>(reinterpret_cast<uintptr_t>(p) ^ q);
   return p;
 }
 
 inline void* UnmaskPtr(void* p) {
   return MaskPtr(p);
 }
 
@@ skipping 141 matching lines @@
 
 namespace {
 
 inline void FL_SetNext(void *t, void *n) {
   tcmalloc::SLL_SetNext(t,n);
 }
 
 }
 
 #endif // TCMALLOC_USE_DOUBLYLINKED_FREELIST