Issue 10957036: Android: creates fifo for test runners in internal directory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10957036: Android: creates fifo for test runners in internal directory. (Closed)

Created:
8 years, 3 months ago by bulach

Modified:
8 years, 3 months ago

Reviewers:
Peter Beverloo

CC:
chromium-reviews, peter+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Android: creates fifo for test runners in internal directory. Some devices have $EXTERNAL_STORAGE filesystems that don't support mkfifo. Create in the internal app dir instead. BUG= TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=157962

Patch Set 1 #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -9 lines)			Patch
M	build/android/pylib/test_package_apk.py	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	testing/android/java/src/org/chromium/native_test/ChromeNativeTestActivity.java	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	testing/android/native_test_launcher.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Philippe

8 years, 3 months ago (2012-09-21 15:42:46 UTC) #3

On 2012/09/21 10:33:35, Peter Beverloo wrote:
> LGTM, thank you!!

Thanks Marcus!

Expand Messages | Collapse Messages