Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Unified Diff: testing/android/native_test_launcher.cc

Issue 10957036: Android: creates fifo for test runners in internal directory. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « testing/android/java/src/org/chromium/native_test/ChromeNativeTestActivity.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: testing/android/native_test_launcher.cc
diff --git a/testing/android/native_test_launcher.cc b/testing/android/native_test_launcher.cc
index 99d9b29b47120badde0f33efb68fb86fd04fb0e9..ade30b2758d99ea781f1282033631d22f426447f 100644
--- a/testing/android/native_test_launcher.cc
+++ b/testing/android/native_test_launcher.cc
@@ -118,7 +118,8 @@ int ArgsToArgv(const std::vector<std::string>& args,
void CreateFIFO(const char* fifo_path) {
unlink(fifo_path);
- if (mkfifo(fifo_path, 0666)) {
+ // Default permissions for mkfifo is ignored, chmod is required.
+ if (mkfifo(fifo_path, 0666) || chmod(fifo_path, 0666)) {
AndroidLogError("Failed to create fifo %s: %s\n",
fifo_path, strerror(errno));
exit(EXIT_FAILURE);
« no previous file with comments | « testing/android/java/src/org/chromium/native_test/ChromeNativeTestActivity.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698