Get real GPU memory values on NV+Linux and OS X

Get real GPU memory values on NV+Linux and OS X. Add an interface to GLContext to query the GPU's total video memory. 

Note that this is the amount of video memory on the currently-rendering GPU, so different contexts will give different values, and the same context may give different values over time (for instance, on a Macbook Pro with graphics switching).

Of note is that on a Macbook Pro with graphics switching enabled, the contexts don't move together between GPUs -- some stay on the integrated GPU while others use the discrete GPU.

BUG=132994
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157879

[ccameron, 2012-09-20 02:12:25]

"git cl try" seems to not work for me lately -- could you add some try-bots
while I try to sort out why they always instantly go read?

[Ken Russell (switch to Gerrit), 2012-09-20 06:47:23]

LGTM if the issues below are fixed.

https://codereview.chromium.org/10957009/diff/10/third_party/mesa/MesaLib/inc...
File third_party/mesa/MesaLib/include/GL/glext.h (right):

https://codereview.chromium.org/10957009/diff/10/third_party/mesa/MesaLib/inc...
third_party/mesa/MesaLib/include/GL/glext.h:5022: #ifndef GL_NVX_gpu_memory_info
Is this really where these #defines need to go to get them picked up by the
command buffer service code? Regardless, I think it would be a good idea to add
them to third_party/khronos/GLES2/gl2ext.h.

https://codereview.chromium.org/10957009/diff/10/ui/gl/gl_context.h
File ui/gl/gl_context.h (right):

https://codereview.chromium.org/10957009/diff/10/ui/gl/gl_context.h#newcode56
ui/gl/gl_context.h:56: virtual bool GetTotalGpuMemory(size_t& bytes);
Google C++ style guide disallows mutable reference arguments. Use size_t*
instead. See http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml .

https://codereview.chromium.org/10957009/diff/10/ui/gl/gl_context_cgl.cc
File ui/gl/gl_context_cgl.cc (right):

https://codereview.chromium.org/10957009/diff/10/ui/gl/gl_context_cgl.cc#newc...
ui/gl/gl_context_cgl.cc:176: CGLRendererInfoObj renderer_info = NULL;
Use ScopedGenericObj parameterized with a ScopedDestroyRendererInfo function.
Refactor if necessary. See src/ui/gl/gl_context_mac.mm.

[ccameron, 2012-09-20 21:22:41]

https://codereview.chromium.org/10957009/diff/10/third_party/mesa/MesaLib/inc...
File third_party/mesa/MesaLib/include/GL/glext.h (right):

https://codereview.chromium.org/10957009/diff/10/third_party/mesa/MesaLib/inc...
third_party/mesa/MesaLib/include/GL/glext.h:5022: #ifndef GL_NVX_gpu_memory_info
On 2012/09/20 06:47:23, kbr wrote:
> Is this really where these #defines need to go to get them picked up by the
> command buffer service code? Regardless, I think it would be a good idea to
add
> them to third_party/khronos/GLES2/gl2ext.h.

I tried to put them in gl2ext.h, but pulling that header didn't work from inside
gl_context_glx.cc (whereas glext.h was already included).

I've added them to gl2ext.h as well -- I feel a bit iffy about putting it in
gl2ext.h because this is not a ES extension (whereas all of the other extensions
have extension #s for both OpenGL and OpenGL ES).  That said, having these
constants available has proved helpful in local debugging through the command
buffer.

https://codereview.chromium.org/10957009/diff/10/ui/gl/gl_context.h
File ui/gl/gl_context.h (right):

https://codereview.chromium.org/10957009/diff/10/ui/gl/gl_context.h#newcode56
ui/gl/gl_context.h:56: virtual bool GetTotalGpuMemory(size_t& bytes);
On 2012/09/20 06:47:23, kbr wrote:
> Google C++ style guide disallows mutable reference arguments. Use size_t*
> instead. See http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml .

Fixed.

[Ken Russell (switch to Gerrit), 2012-09-20 21:28:37]

LGTM again.

[commit-bot: I haz the power, 2012-09-20 21:32:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ccameron@chromium.org/10957009/5010

[commit-bot: I haz the power, 2012-09-21 00:24:04]

Change committed as 157879