Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1095433005: Force another diagnostic reporting path to be warn-only on Windows. (Closed)

Created:
5 years, 8 months ago by dcheng
Modified:
5 years, 8 months ago
Reviewers:
hans, Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Force another diagnostic reporting path to be warn-only on Windows. BUG=467287 R=thakis@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/ddb810597d4461433a201f47d9382274d49de95d

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M tools/clang/plugins/ChromeClassTester.cpp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M tools/clang/plugins/FindBadConstructsConsumer.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
dcheng
>_< Sorry for not catching this.
5 years, 8 months ago (2015-04-16 18:08:30 UTC) #2
Nico
lgtm https://codereview.chromium.org/1095433005/diff/1/tools/clang/plugins/ChromeClassTester.cpp File tools/clang/plugins/ChromeClassTester.cpp (right): https://codereview.chromium.org/1095433005/diff/1/tools/clang/plugins/ChromeClassTester.cpp#newcode99 tools/clang/plugins/ChromeClassTester.cpp:99: #if !defined(LLVM_ON_WIN32) maybe add a '// TODO: make ...
5 years, 8 months ago (2015-04-16 18:23:29 UTC) #3
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/ddb810597d4461433a201f47d9382274d49de95d Cr-Commit-Position: refs/heads/master@{#325481}
5 years, 8 months ago (2015-04-16 18:29:03 UTC) #4
dcheng
5 years, 8 months ago (2015-04-16 18:29:25 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
ddb810597d4461433a201f47d9382274d49de95d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698