| Index: tools/clang/plugins/FindBadConstructsConsumer.cpp
|
| diff --git a/tools/clang/plugins/FindBadConstructsConsumer.cpp b/tools/clang/plugins/FindBadConstructsConsumer.cpp
|
| index 4c40d52faae694983d4b18f5fdc8643bdf1eb6e7..2524550e6369bd1b13a2c6ec7e024179fc1070d7 100644
|
| --- a/tools/clang/plugins/FindBadConstructsConsumer.cpp
|
| +++ b/tools/clang/plugins/FindBadConstructsConsumer.cpp
|
| @@ -560,8 +560,8 @@ FindBadConstructsConsumer::CheckRecordForRefcountIssue(
|
| // -Werror.
|
| DiagnosticsEngine::Level FindBadConstructsConsumer::getErrorLevel() {
|
| #if defined(LLVM_ON_WIN32)
|
| - // Only warn on Windows, since there are a lot of potential pre-existing
|
| - // issues.
|
| + // TODO(dcheng): Re-enable -Werror for these diagnostics on Windows once all
|
| + // the pre-existing warnings are cleaned up. https://crbug.com/467287
|
| return DiagnosticsEngine::Warning;
|
| #else
|
| return diagnostic().getWarningsAsErrors() ? DiagnosticsEngine::Error
|
|
|