Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issue 1095303004: Make Menu.findMenuItem_ return the first MenuItem. (Closed)

Created:
5 years, 8 months ago by xiyuan
Modified:
5 years, 8 months ago
CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make Menu.findMenuItem_ return the first MenuItem. This fixes the regression in http://crbug.com/480381 where 'activate' event is not fired for menu items under a grouping div rather than being direct children of a Menu. Also fixes js error when hovering such menu items. BUG=480381 Committed: https://crrev.com/95a989fc01c61f3261b1b9723efab0b0c6be56a3 Cr-Commit-Position: refs/heads/master@{#327080}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/webui/resources/js/cr/ui/menu.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
xiyuan
5 years, 8 months ago (2015-04-23 20:46:35 UTC) #2
Dan Beam
this seems fine to me but arv@ is probably a better reviewer for this
5 years, 8 months ago (2015-04-23 21:33:01 UTC) #4
arv (Not doing code reviews)
LGTM This seems fine to me.
5 years, 8 months ago (2015-04-27 17:34:15 UTC) #5
xiyuan
On 2015/04/27 17:34:15, arv wrote: > LGTM > > This seems fine to me. Cool. ...
5 years, 8 months ago (2015-04-27 17:34:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1095303004/1
5 years, 8 months ago (2015-04-27 17:35:13 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-27 18:31:18 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-27 18:33:06 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/95a989fc01c61f3261b1b9723efab0b0c6be56a3
Cr-Commit-Position: refs/heads/master@{#327080}

Powered by Google App Engine
This is Rietveld 408576698