ui/webui/resources/js/cr/ui/menu.js - Issue 1095303004: Make Menu.findMenuItem_ return the first MenuItem.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/webui/resources/js/cr/ui/menu.js

Issue 1095303004: Make Menu.findMenuItem_ return the first MenuItem. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/webui/resources/js/cr/ui/menu.js

diff --git a/ui/webui/resources/js/cr/ui/menu.js b/ui/webui/resources/js/cr/ui/menu.js

index 22d93b4dba6db32f07f4e4b3a61be7454d807ddf..d54f5430f855a9239caaa9ba9af714054acae0db 100644

--- a/ui/webui/resources/js/cr/ui/menu.js

+++ b/ui/webui/resources/js/cr/ui/menu.js

@@ -88,7 +88,7 @@ cr.define('cr.ui', function() {

* @private

findMenuItem_: function(node) {

- while (node && node.parentNode != this) {

+ while (node && node.parentNode != this && !(node instanceof MenuItem)) {

node = node.parentNode;

}

return node ? assertInstanceof(node, MenuItem) : null;

« no previous file with comments | « no previous file | no next file » | no next file with comments »