Issue 1095243002: [chrome/browser/android] favor DCHECK_CURRENTLY_ON for better logs

Issue 1095243002: [chrome/browser/android] favor DCHECK_CURRENTLY_ON for better logs (Closed)

Created:
5 years, 8 months ago by anujsharma

Modified:
5 years, 8 months ago

Reviewers:
Lei Zhang

CC:
chromium-reviews, Mostyn Bramley-Moore

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/android BUG=466848 Committed: https://crrev.com/eb234b76120f050639eb91e574c8956f66683b01 Cr-Commit-Position: refs/heads/master@{#326226}

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -12 lines)			Patch
M	chrome/browser/android/chromium_application.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/android/cookies/cookies_fetcher.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/android/download/chrome_download_manager_overwrite_infobar_delegate.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/android/provider/blocking_ui_thread_async_request.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/android/provider/run_on_ui_thread_blocking.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/android/thumbnail/thumbnail_store.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/android/webapps/single_tab_mode_tab_helper.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download

Total messages: 8 (2 generated)

Lei Zhang

lgtm Note: you can ask someone in chrome/browser/android/OWNERS for a CL like this one.

5 years, 8 months ago (2015-04-21 21:15:03 UTC) #3

anujsharma

On 2015/04/21 21:15:03, Lei Zhang wrote: > lgtm > > Note: you can ask someone ...

5 years, 8 months ago (2015-04-22 03:08:14 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1095243002/1

5 years, 8 months ago (2015-04-22 03:08:27 UTC) #6

commit-bot: I haz the power

5 years, 8 months ago (2015-04-22 03:47:06 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/eb234b76120f050639eb91e574c8956f66683b01
Cr-Commit-Position: refs/heads/master@{#326226}