chrome/browser/android/download/chrome_download_manager_overwrite_infobar_delegate.cc - Issue 1095243002: [chrome/browser/android] favor DCHECK_CURRENTLY_ON for better logs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/download/chrome_download_manager_overwrite_infobar_delegate.cc

Issue 1095243002: [chrome/browser/android] favor DCHECK_CURRENTLY_ON for better logs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/cookies/cookies_fetcher.cc ('k') | chrome/browser/android/provider/blocking_ui_thread_async_request.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/download/chrome_download_manager_overwrite_infobar_delegate.cc

diff --git a/chrome/browser/android/download/chrome_download_manager_overwrite_infobar_delegate.cc b/chrome/browser/android/download/chrome_download_manager_overwrite_infobar_delegate.cc

index f4002b4e2fc5a03b6996e7dcd86aee2e8197e28b..d4c0cf8c4c7fdbc88895c1076a8e2c92f8fa4c5a 100644

--- a/chrome/browser/android/download/chrome_download_manager_overwrite_infobar_delegate.cc

+++ b/chrome/browser/android/download/chrome_download_manager_overwrite_infobar_delegate.cc

@@ -73,7 +73,7 @@ void ChromeDownloadManagerOverwriteInfoBarDelegate::InfoBarDismissed() {

void ChromeDownloadManagerOverwriteInfoBarDelegate::CreateNewFileInternal(

const base::FilePath& suggested_download_path,

const DownloadTargetDeterminerDelegate::FileSelectedCallback& callback) {

- DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::FILE));

+ DCHECK_CURRENTLY_ON(content::BrowserThread::FILE);

int uniquifier = base::GetUniquePathNumber(suggested_download_path,

base::FilePath::StringType());

base::FilePath new_path = suggested_download_path;