[Chromoting] Remove CRD-specific JS files from AppRemoting build.

[Chromoting] Remove CRD-specific JS files from AppRemoting build.

Recent refactoring allows us to remove many CRD-specific files from
the set of "common" JS files. This cl moves the CRD UI JS files
out of the AppRemoting build. This is in preparation for removing
Application.Mode in a follow-up cl.

Requires that crrev.com/1109453005 land first.

BUG=

Committed: https://crrev.com/5b228c89815b79a39fb4d1520f99e4de96e1ed2c
Cr-Commit-Position: refs/heads/master@{#327205}

[garykac, 2015-04-24 23:40:40]

garykac@chromium.org changed reviewers:
+ kelvinp@chromium.org

[kelvinp, 2015-04-27 17:18:28]

lgtm

https://codereview.chromium.org/1095203010/diff/20001/remoting/remoting_webap...
File remoting/remoting_webapp_files.gypi (right):

https://codereview.chromium.org/1095203010/diff/20001/remoting/remoting_webap...
remoting/remoting_webapp_files.gypi:248: 'webapp/crd/js/ui_mode.js',
Not related to this CL, why does app_remoting depends on setMode()?  From code
search, the only use case is to set the appMode as CONNECTING.  Not sure if this
is actually necessary since we got a loading window in app remoting.

[garykac, 2015-04-27 17:32:28]

The CQ bit was checked by garykac@chromium.org

[commit-bot: I haz the power, 2015-04-27 17:33:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1095203010/20001

[garykac, 2015-04-27 17:36:28]

https://codereview.chromium.org/1095203010/diff/20001/remoting/remoting_webap...
File remoting/remoting_webapp_files.gypi (right):

https://codereview.chromium.org/1095203010/diff/20001/remoting/remoting_webap...
remoting/remoting_webapp_files.gypi:248: 'webapp/crd/js/ui_mode.js',
On 2015/04/27 17:18:28, kelvinp wrote:
> Not related to this CL, why does app_remoting depends on setMode()?  From code
> search, the only use case is to set the appMode as CONNECTING.  Not sure if
this
> is actually necessary since we got a loading window in app remoting.

The intent is that ui_mode should eventually go away from AppRemoting. But as
you say, it'll have to be in a separate cl since it will require some work.

[Jamie, 2015-04-27 18:49:38]

On 2015/04/27 17:36:28, garykac wrote:
>
https://codereview.chromium.org/1095203010/diff/20001/remoting/remoting_webap...
> File remoting/remoting_webapp_files.gypi (right):
> 
>
https://codereview.chromium.org/1095203010/diff/20001/remoting/remoting_webap...
> remoting/remoting_webapp_files.gypi:248: 'webapp/crd/js/ui_mode.js',
> On 2015/04/27 17:18:28, kelvinp wrote:
> > Not related to this CL, why does app_remoting depends on setMode()?  From
code
> > search, the only use case is to set the appMode as CONNECTING.  Not sure if
> this
> > is actually necessary since we got a loading window in app remoting.
> 
> The intent is that ui_mode should eventually go away from AppRemoting. But as
> you say, it'll have to be in a separate cl since it will require some work.

Drive-by: Now that we have <dialog>, the concept of UI modes is rather
heavyweight and could probably be eliminated entirely. We basically only have
two modes--in session and home--with everything else being a dialog overlaid on
the home screen.

[commit-bot: I haz the power, 2015-04-27 18:56:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-27 18:56:21]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[garykac, 2015-04-28 00:04:46]

The CQ bit was checked by garykac@chromium.org

[garykac, 2015-04-28 00:04:46]

The patchset sent to the CQ was uploaded after l-g-t-m from kelvinp@chromium.org
Link to the patchset: https://codereview.chromium.org/1095203010/#ps40001
(title: "Move crd_main.js out of shared")

[commit-bot: I haz the power, 2015-04-28 00:05:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1095203010/40001

[commit-bot: I haz the power, 2015-04-28 01:03:15]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-04-28 01:04:04]

Patchset 3 (id:??) landed as
https://crrev.com/5b228c89815b79a39fb4d1520f99e4de96e1ed2c
Cr-Commit-Position: refs/heads/master@{#327205}