[Chromoting] Remove CRD-specific JS files from AppRemoting build.

remoting/remoting_webapp_files.gypi

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # Keep in sync with remoting/webapp/files.gni.
 
 {
   'variables': {
 
     # Jscompile proto files.
@@ skipping 149 matching lines @@
       'webapp/crd/js/activity.js',
       'webapp/crd/js/client_plugin.js',
       'webapp/crd/js/client_plugin_impl.js',
       'webapp/crd/js/client_plugin_host_desktop_impl.js',
       'webapp/crd/js/client_session.js',
       'webapp/crd/js/client_session_factory.js',
       'webapp/crd/js/clipboard.js',
       'webapp/crd/js/connected_view.js',
       'webapp/crd/js/connection_info.js',
       'webapp/crd/js/credentials_provider.js',
-      'webapp/crd/js/desktop_connected_view.js',
       'webapp/crd/js/host_desktop.js',
       'webapp/crd/js/smart_reconnector.js',
       'webapp/crd/js/video_frame_recorder.js',
     ],
     # Remoting core JavaScript files.
     'remoting_webapp_js_core_files': [
       'webapp/base/js/app_capabilities.js',
       'webapp/base/js/application.js',
       'webapp/base/js/base.js',
       'webapp/base/js/ipc.js',
@@ skipping 51 matching lines @@
       'webapp/crd/js/dns_blackhole_checker.js',
       'webapp/crd/js/fallback_signal_strategy.js',
       'webapp/crd/js/signal_strategy.js',
       'webapp/crd/js/tcp_socket.js',
       'webapp/crd/js/wcs_adapter.js',
       'webapp/crd/js/wcs_sandbox_container.js',
       'webapp/crd/js/xmpp_connection.js',
       'webapp/crd/js/xmpp_login_handler.js',
       'webapp/crd/js/xmpp_stream_parser.js',
     ],
-    # UI JavaScript files.
+    # Shared UI JavaScript files.
     'remoting_webapp_js_ui_files': [
       'webapp/base/js/viewport.js',
       'webapp/base/js/window_shape.js',
+      'webapp/crd/js/connection_stats.js',
+      'webapp/crd/js/feedback.js',
+      'webapp/crd/js/l10n.js',
+      'webapp/crd/js/ui_mode.js',

[kelvinp, 2015/04/27 17:18:28]

Not related to this CL, why does app_remoting depends on setMode()?  From code
search, the only use case is to set the appMode as CONNECTING.  Not sure if this
is actually necessary since we got a loading window in app remoting.

[garykac, 2015/04/27 17:36:28]

The intent is that ui_mode should eventually go away from AppRemoting. But as
you say, it'll have to be in a separate cl since it will require some work.

+    ],
+
+    #
+    # DesktopRemoting-specific JS files.
+    #
+
+    # The CRD-specific JavaScript files required by main.html.
+    'remoting_webapp_crd_js_ui_files': [
       'webapp/crd/js/bump_scroller.js',
       'webapp/crd/js/butter_bar.js',
-      'webapp/crd/js/connection_stats.js',
+      'webapp/crd/js/crd_auth_dialog.js',
+      'webapp/crd/js/crd_event_handlers.js',
+      'webapp/crd/js/crd_experimental.js',
+      'webapp/crd/js/crd_main.js',
+      'webapp/crd/js/desktop_connected_view.js',
+      'webapp/crd/js/desktop_remoting.js',
+      'webapp/crd/js/desktop_remoting_activity.js',
       'webapp/crd/js/desktop_viewport.js',
-      'webapp/crd/js/feedback.js',
       'webapp/crd/js/fullscreen.js',
       'webapp/crd/js/fullscreen_v1.js',
       'webapp/crd/js/fullscreen_v2.js',
-      'webapp/crd/js/l10n.js',
+      'webapp/crd/js/it2me_activity.js',
+      'webapp/crd/js/me2me_activity.js',
       'webapp/crd/js/menu_button.js',
       'webapp/crd/js/options_menu.js',
-      'webapp/crd/js/ui_mode.js',
       'webapp/crd/js/toolbar.js',
       'webapp/crd/js/window_frame.js',
     ],
 
     #
     # DesktopRemoting main.html generation files.
     #
 
     'remoting_webapp_template_main':
       '<(DEPTH)/remoting/webapp/crd/html/template_main.html',
@@ skipping 15 matching lines @@
       '<@(remoting_webapp_js_ui_files)',
       '<@(remoting_webapp_js_signaling_files)',
       # Uncomment this line to include browser test files in the web app
       # to expedite debugging or local development.
       #'<@(remoting_webapp_browsertest_all_js_files)',
     ],
 
     # The CRD-specific JavaScript files required by main.html.
     'remoting_webapp_crd_main_html_all_js_files': [
       '<@(remoting_webapp_shared_main_html_js_files)',
-      'webapp/crd/js/crd_auth_dialog.js',
-      'webapp/crd/js/crd_event_handlers.js',
-      'webapp/crd/js/crd_experimental.js',
-      'webapp/crd/js/crd_main.js',
-      'webapp/crd/js/desktop_remoting.js',
-      'webapp/crd/js/desktop_remoting_activity.js',
-      'webapp/crd/js/it2me_activity.js',
-      'webapp/crd/js/me2me_activity.js',
+      '<@(remoting_webapp_crd_js_ui_files)',
     ],
 
     # These template files are used to construct main.html.
     'remoting_webapp_template_files': [
       'webapp/base/html/client_plugin.html',
       'webapp/crd/html/butter_bar.html',
       'webapp/crd/html/dialog_auth.html',
       'webapp/crd/html/dialog_client_connect_failed.html',
       'webapp/crd/html/dialog_client_connecting.html',
       'webapp/crd/html/dialog_client_host_needs_upgrade.html',
@@ skipping 167 matching lines @@
       '<(remoting_webapp_template_background)',
       '<(remoting_webapp_template_main)',
       '<(remoting_webapp_template_message_window)',
       '<(remoting_webapp_template_wcs_sandbox)',
       '<@(remoting_webapp_template_files)',
       '<@(remoting_webapp_crd_js_files)',
     ],
 
   },
 }