Issue 1095183004: [chrome/browser/t*] favor DCHECK_CURRENTLY_ON for better logs

Issue 1095183004: [chrome/browser/t*] favor DCHECK_CURRENTLY_ON for better logs (Closed)

Created:
5 years, 8 months ago by anujsharma

Modified:
5 years, 8 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
chromium-reviews, Mostyn Bramley-Moore

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/thumbnails, task_management, themes BUG=466848 Committed: https://crrev.com/80f8ac058243cc19d45131ddc36b44672dca8811 Cr-Commit-Position: refs/heads/master@{#326446}

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -14 lines)			Patch
M	chrome/browser/task_management/providers/child_process_task_provider.cc	View	1	6 chunks	+7 lines, -7 lines	0 comments	Download
M	chrome/browser/themes/browser_theme_pack.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/thumbnails/content_based_thumbnailing_algorithm.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/thumbnails/simple_thumbnail_crop.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/thumbnails/thumbnail_service_impl.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/thumbnails/thumbnail_tab_helper.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 8 (2 generated)

anujsharma

On 2015/04/22 14:49:05, jochen wrote: > lgtm Thanks jochen for lgtm.

5 years, 8 months ago (2015-04-23 02:10:29 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1095183004/20001

5 years, 8 months ago (2015-04-23 02:11:37 UTC) #6

commit-bot: I haz the power

5 years, 8 months ago (2015-04-23 04:13:20 UTC) #8

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/80f8ac058243cc19d45131ddc36b44672dca8811
Cr-Commit-Position: refs/heads/master@{#326446}