chrome/browser/themes/browser_theme_pack.cc - Issue 1095183004: [chrome/browser/t*] favor DCHECK_CURRENTLY_ON for better logs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/themes/browser_theme_pack.cc

Issue 1095183004: [chrome/browser/t*] favor DCHECK_CURRENTLY_ON for better logs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Adding files Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/task_management/providers/child_process_task_provider.cc ('k') | chrome/browser/thumbnails/content_based_thumbnailing_algorithm.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/themes/browser_theme_pack.cc

diff --git a/chrome/browser/themes/browser_theme_pack.cc b/chrome/browser/themes/browser_theme_pack.cc

index 81755840371ef49a4c4d23de70626f965fa716e6..53f5de789dd1df4f78e0cf71d02381a6e4521390 100644

--- a/chrome/browser/themes/browser_theme_pack.cc

+++ b/chrome/browser/themes/browser_theme_pack.cc

@@ -651,7 +651,7 @@ BrowserThemePack::~BrowserThemePack() {

// static

scoped_refptr<BrowserThemePack> BrowserThemePack::BuildFromExtension(

const Extension* extension) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

DCHECK(extension);

DCHECK(extension->is_theme());

@@ -712,7 +712,7 @@ scoped_refptr<BrowserThemePack> BrowserThemePack::BuildFromExtension(

// static

scoped_refptr<BrowserThemePack> BrowserThemePack::BuildFromDataPack(

const base::FilePath& path, const std::string& expected_id) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

// Allow IO on UI thread due to deep-seated theme design issues.

// (see http://crbug.com/80206)

base::ThreadRestrictions::ScopedAllowIO allow_io;