Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(823)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/public/browser/content_browser_client.h

Issue 10949027: Close leaking FDs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« content/browser/child_process_launcher.cc ('K') | « content/public/android/java/src/org/chromium/content/browser/SandboxedProcessConnection.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/content_browser_client.h
diff --git a/content/public/browser/content_browser_client.h b/content/public/browser/content_browser_client.h
index 7766f55d418683d958e06c2b3fe93e286e2d258c..d24978f1861e91f2c91f76d8769d52297757b3f9 100644
--- a/content/public/browser/content_browser_client.h
+++ b/content/public/browser/content_browser_client.h
@@ -450,7 +450,10 @@ class CONTENT_EXPORT ContentBrowserClient {
#if defined(OS_POSIX) && !defined(OS_MACOSX)
// Populates |mappings| with all files that need to be mapped before launching
- // a child process.
+ // a child process. Note that the caller takes ownership of the file
+ // descriptors returned in mappings, meaning you should not close them after
+ // that call and you must dup them if you need to use them after this method
+ // is called.
virtual void GetAdditionalMappedFilesForChildProcess(
const CommandLine& command_line,
base::GlobalDescriptors::Mapping* mappings) {}
« content/browser/child_process_launcher.cc ('K') | « content/public/android/java/src/org/chromium/content/browser/SandboxedProcessConnection.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698