Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Unified Diff: content/browser/child_process_launcher.cc

Issue 10949027: Close leaking FDs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/child_process_launcher.cc
diff --git a/content/browser/child_process_launcher.cc b/content/browser/child_process_launcher.cc
index f7cf77224f44e04e098f4b121c9d4f2e73c5f00d..ae5dbcb9c96a0d6c25c48d6f94fc7f90af79afd6 100644
--- a/content/browser/child_process_launcher.cc
+++ b/content/browser/child_process_launcher.cc
@@ -167,8 +167,6 @@ class ChildProcessLauncher::Context
std::string process_type =
cmd_line->GetSwitchValueASCII(switches::kProcessType);
base::GlobalDescriptors::Mapping files_to_register;
- files_to_register.push_back(std::pair<base::GlobalDescriptors::Key, int>(
- kPrimaryIPCChannel, ipcfd));
Jay Civelli 2012/09/19 22:58:57 Not sure why this was done. The IPC FD is special
Yaron 2012/09/20 00:01:54 Are you sure this is right? I thought we've always
content::GetContentClient()->browser()->
GetAdditionalMappedFilesForChildProcess(*cmd_line, &files_to_register);

Powered by Google App Engine
This is Rietveld 408576698