Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: src/trusted/validator_arm/inst_classes.h

Issue 10949006: Change table data_processing_immediate to use the new notation. Also (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/trusted/validator_arm/gen/arm32_decode_named_decoder.h ('k') | src/trusted/validator_arm/problem_reporter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/trusted/validator_arm/inst_classes.h
===================================================================
--- src/trusted/validator_arm/inst_classes.h (revision 9791)
+++ src/trusted/validator_arm/inst_classes.h (working copy)
@@ -42,6 +42,11 @@
// This instruction's operands are forbidden by our SFI model.
FORBIDDEN_OPERANDS,
+ // This instruction was decoded incorrectly, because it should have decoded
+ // as a different instruction. This value should never occur, unless there
+ // is a bug in our decoder tables (in file armv7.table).
+ DECODER_ERROR,
+
// This instruction may be safe in untrusted code: in isolation it contains
// nothing scary, but the validator may overrule this during global analysis.
MAY_BE_SAFE
« no previous file with comments | « src/trusted/validator_arm/gen/arm32_decode_named_decoder.h ('k') | src/trusted/validator_arm/problem_reporter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698