Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: src/api.cc

Issue 1094863002: Remove the weak list of views from array buffers (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: updates Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/accessors.cc ('k') | src/elements.h » ('j') | src/heap/heap.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/api.cc
diff --git a/src/api.cc b/src/api.cc
index 3a89095d0b7344512dbbd6658d816f09bd851322..6294b21f8fdd1b626992c9795da576be49f6a7b3 100644
--- a/src/api.cc
+++ b/src/api.cc
@@ -6340,6 +6340,7 @@ size_t v8::ArrayBufferView::CopyContents(void* dest, size_t byte_length) {
source = reinterpret_cast<char*>(buffer->backing_store());
}
}
+ if (!source) return 0;
Hannes Payer (out of office) 2015/04/22 07:45:53 Isn't that more an assert? source is not null when
jochen (gone - plz use gerrit) 2015/04/22 08:21:42 true. if it's neutered, byte_length() above will b
memcpy(dest, source + byte_offset, bytes_to_copy);
}
return bytes_to_copy;
« no previous file with comments | « src/accessors.cc ('k') | src/elements.h » ('j') | src/heap/heap.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698