Remove the weak list of views from array buffers

src/api.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/api.h"
 
 #include <string.h>  // For memcpy, strlen.
 #ifdef V8_USE_ADDRESS_SANITIZER
 #include <sanitizer/asan_interface.h>
 #endif  // V8_USE_ADDRESS_SANITIZER
@@ skipping 6322 matching lines @@
       if (typed_array->buffer()->IsSmi()) {
         i::Handle<i::FixedTypedArrayBase> fixed_array(
             i::FixedTypedArrayBase::cast(typed_array->elements()));
         source = reinterpret_cast<char*>(fixed_array->DataPtr());
       } else {
         i::Handle<i::JSArrayBuffer> buffer(
             i::JSArrayBuffer::cast(typed_array->buffer()));
         source = reinterpret_cast<char*>(buffer->backing_store());
       }
     }
+    if (!source) return 0;

[Hannes Payer (out of office), 2015/04/22 07:45:53]

Isn't that more an assert? source is not null when not neutered?

[jochen (gone - plz use gerrit), 2015/04/22 08:21:42]

true. if it's neutered, byte_length() above will be zero, and so we shouldn't
get here at all

turning this into an assert() doesn't really help, because the memcpy will just
crash as well

     memcpy(dest, source + byte_offset, bytes_to_copy);
   }
   return bytes_to_copy;
 }
 
 
 bool v8::ArrayBufferView::HasBuffer() const {
   i::Handle<i::JSArrayBufferView> obj = Utils::OpenHandle(this);
   if (obj->IsJSDataView()) return true;
   DCHECK(obj->IsJSTypedArray());
@@ skipping 1656 matching lines @@
   Isolate* isolate = reinterpret_cast<Isolate*>(info.GetIsolate());
   Address callback_address =
       reinterpret_cast<Address>(reinterpret_cast<intptr_t>(callback));
   VMState<EXTERNAL> state(isolate);
   ExternalCallbackScope call_scope(isolate, callback_address);
   callback(info);
 }
 
 
 } }  // namespace v8::internal